Update capi pkg to v1.8.1 #80
Conversation
| @@ -30,7 +30,7 @@ spec: | |||
| enabled: true | |||
| enforce: baseline | |||
| warn: restricted | |||
| version: v1.26.3 | |||
| version: v1.31.0 | |||
There was a problem hiding this comment.
Would not just updating the kptfile help rather than updating the actual files every time?I could be wrong
There was a problem hiding this comment.
There are quite a few changes to the whole pkg so I don't think so. Changes to the CRDs etc.
There was a problem hiding this comment.
FYI It seems like we should be using something like the link below for changing image names and tags
https://catalog.kpt.dev/set-image/v0.1/set-image-simple/
There was a problem hiding this comment.
I would somewhat agree but this is the base k8s version to be used in the workload clusters.
We could look to set this value dynamically later if needed but for now I am just updating the base version of each 3pp component.
|
/approve |
|
@efiacor Thanks for the PR, the PR has a lot of changes. What's a good way for a reviewer to test out changes in a local environment. ? Any steps you can share would be appreciated. Thanks |
| @@ -3,7 +3,6 @@ kind: Namespace | |||
| metadata: | |||
| labels: | |||
| cluster.x-k8s.io/provider: infrastructure-docker | |||
| clusterctl.cluster.x-k8s.io: "" | |||
There was a problem hiding this comment.
Curious as to why this is being removed. Is removing this related to updating the capi pkg to v1.8.1?
There was a problem hiding this comment.
May be somewhat of a clumsy way of doing this upgrade but most of the CRD changes are being pulled in from the assets here - https://github.com/kubernetes-sigs/cluster-api/releases/tag/v1.8.1
There was a problem hiding this comment.
@efiacor Thanks for the response,
For this particular change, what is the corresponding file from https://github.com/kubernetes-sigs/cluster-api/releases/tag/v1.8.1 that drove the change? Thanks
There was a problem hiding this comment.
| cluster.x-k8s.io/v1beta1: v1beta1 | ||
| clusterctl.cluster.x-k8s.io: "" |
There was a problem hiding this comment.
Curious as to why the labels at L22 and L24 are being removed? Thanks
| @@ -46,6 +41,154 @@ spec: | |||
| singular: dockercluster | |||
| scope: Namespaced | |||
| versions: | |||
| - deprecated: true | |||
There was a problem hiding this comment.
Trying to understand why L44 to L191 is being added now, seems like this is being set as deprecated as well.
There was a problem hiding this comment.
@efiacor Thanks for the response,
For this particular change, what is the corresponding file from https://github.com/kubernetes-sigs/cluster-api/releases/tag/v1.8.1 that drove the change? Thanks
| @@ -389,32 +549,22 @@ spec: | |||
| storage: true | |||
| subresources: | |||
| status: {} | |||
| status: | |||
There was a problem hiding this comment.
Curious as to why this section is being removed? Thanks
Thanks for reviewing @vjayaramrh . sudo -E NEPHIO_REPO_DIR=/home/ubuntu/test-infra NEPHIO_DEBUG=false NEPHIO_USER=ubuntu NEPHIO_CATALOG_REPO_URI=https://github.com/efiacor/nephio-pkg-catalog.git K8S_VERSION=v1.31.0 ./init.sh |
|
FYI Reviewed to be able to understand the changes, hopefully, someone else who is an expert can review as well and approve the merge |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arora-sagar, efiacor, liamfallon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
nephio-project/nephio#800
Support for k8s v1.31.0
Tested and verified on free5gc e2e suite