Initial commit #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds and one robot. Co-authored-by: Matthias Holoch <[email protected]> Co-authored-by: Justus Braun <[email protected]>
Cakem1x
approved these changes
Oct 26, 2024
There was a problem hiding this comment.
I added a few commits, so maybe you can squash merge after all :D
- slight adaptation to readme to make installation guide more copyable
- formatting CPP and python for happy linters
For CPP formatting, you can run ament_uncrustify --reformat from CLI. For Python, the ament tool is ament_flake8. Unfortunately, it does not have a reformat option. So we use ruff at Nature Robots (see other comment).
I tested that the tutorial stack still works for one env.
There was a problem hiding this comment.
I added a pyproject.toml file. We use this with the ruff python formatter. The formatter, when using this config, abides to the ROS 2 default config that ament_flake8 uses. I think it's nice if we have the "default" ROS 2 style.
Linelength of only 99 is a bit annoying, though, but I can live with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the initial commit of the mesh navigation tutorials. Since I have copy-pasted all things from our dev repo someone might do a last check if its still working before merging.