More docstrings #34
Merged
More docstrings #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `narwhals.dataframe.DataFrame.unique` docstring
- Add `narwhals.dataframe.DataFrame.sort` docstring
- Add `narwhals.dataframe.DataFrame.join` docstring
MarcoGorelli
approved these changes
Mar 31, 2024
There was a problem hiding this comment.
nice one, thanks @frnmst !
I just kept join inner for now, as the others aren't (yet) supported - but I'll restore these example later when they are
Ah, OK. I though the fact that was working as expected it meant that it was implemented. But now I just noticed: if how not in ["inner"]:
msg = "Only inner join supported for now, others coming soon"
raise ValueError(msg)in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docstrings for:
narwhals.dataframe.DataFrame.uniquenarwhals.dataframe.DataFrame.sortnarwhals.dataframe.DataFrame.joinYou can create a new base
docstringsbranch from yourmainbefore merging since I can't do it with my user