Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework nano::thread_pool #4762

Merged
merged 9 commits into from
Oct 27, 2024
Merged

Conversation

pwojcikdev
Copy link
Contributor

The main issue with previous code was that it copied queued functions, which was inefficient and prevented using move-only function handlers. This also does some cleanup.

@qwahzi qwahzi added this to the V28 milestone Oct 22, 2024
@gr0vity-dev-bot
Copy link

gr0vity-dev-bot commented Oct 22, 2024

Test Results for Commit e9b0751

Pull Request 4762: Results
Overall Status:

Test Case Results

  • 5n4pr_conf_10k_bintree: PASS (Duration: 111s)
  • 5n4pr_conf_10k_change: PASS (Duration: 216s)
  • 5n4pr_conf_change_dependant: PASS (Duration: 153s)
  • 5n4pr_conf_change_independant: PASS (Duration: 151s)
  • 5n4pr_conf_send_dependant: PASS (Duration: 126s)
  • 5n4pr_conf_send_independant: PASS (Duration: 139s)
  • 5n4pr_rocks_10k_bintree: PASS (Duration: 108s)
  • 5n4pr_rocks_10k_change: PASS (Duration: 238s)

Last updated: 2024-10-23 11:23:52 UTC

@gr0vity-dev-bot
Copy link

Test Results for Commit f53f1f8

Pull Request 4762: Results
Overall Status:

Test Case Results

  • 5n4pr_conf_10k_bintree: PASS (Duration: 113s)
  • 5n4pr_conf_10k_change: PASS (Duration: 227s)
  • 5n4pr_conf_change_dependant: PASS (Duration: 144s)
  • 5n4pr_conf_change_independant: PASS (Duration: 152s)
  • 5n4pr_conf_send_dependant: PASS (Duration: 133s)
  • 5n4pr_conf_send_independant: PASS (Duration: 141s)
  • 5n4pr_rocks_10k_bintree: PASS (Duration: 114s)
  • 5n4pr_rocks_10k_change: PASS (Duration: 191s)

Last updated: 2024-10-22 16:43:04 UTC

@RickiNano
Copy link
Contributor

@pwojcikdev
Windows builds doesn't compile. It can be fixed by changing line 58 of thread_pool.hpp to
boost::asio::use_service<boost::asio::detail::win_iocp_io_context> (*thread_pool_impl).stop ();

@pwojcikdev
Copy link
Contributor Author

Thanks @RickiNano

@pwojcikdev pwojcikdev merged commit bdf4668 into nanocurrency:develop Oct 27, 2024
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged / V28.0
Development

Successfully merging this pull request may close these issues.

5 participants