Offload block processor notifications #4763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results for Commit bac144fPull Request 4763: Results Test Case Results
Last updated: 2024-10-28 09:33:34 UTC |
pwojcikdev
force-pushed
the
offload-block-processor-notifications
branch
2 times, most recently
from
2a1b379 to
8fb8dc2
Compare
|
Related tests from @gr0vity-dev, showing the reduction in delays for "block processed" to "publish sent" under load:
|
pwojcikdev
force-pushed
the
offload-block-processor-notifications
branch
from
8fb8dc2 to
1a2e6ed
Compare
clemahieu
previously approved these changes
Oct 27, 2024
| @@ -255,6 +255,7 @@ nano::container_info nano::confirming_set::container_info () const | |||
|
|
|||
| nano::container_info info; | |||
| info.put ("set", set); | |||
| info.add ("notification_workers", notification_workers.container_info ()); | |||
| info.put ("notifications", workers.queued_tasks ()); | |||
There was a problem hiding this comment.
Is this already added with workers.container_info() below?
There was a problem hiding this comment.
This might be redundant, right
pwojcikdev
dismissed
clemahieu’s stale review
The merge-base changed after approval.
pwojcikdev
force-pushed
the
offload-block-processor-notifications
branch
from
5e206ec to
bac144f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This offloads block processors notifications to be processed on a background thread, so that block processor can continue checking new blocks without waiting for other components to do their work. Checking new blocks requires a write-transaction, while handling
batch_processedevent is done with read-only transaction, both can happen in parallel.The changes here are based on top of #4762 which is a necessary prerequisite.