Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Log tweaks #195

Merged
merged 2 commits into from
Dec 29, 2023
Merged

chore: Log tweaks #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61024f1
Commands are logged after executing. Current wording is misleading.
fritzduchardt Dec 29, 2023
cef1ce5
Corrected log message for plugin execution failure
fritzduchardt Dec 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/plugin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ func newPluginCmd(plugin myks.Plugin) *cobra.Command {
}

if err := g.ExecPlugin(asyncLevel, plugin, pluginArgs); err != nil {
log.Fatal().Err(err).Msg("Unable to render applications")
log.Fatal().Err(err).Msg("Plugin did not run successfully")
return err
}

Expand Down
4 changes: 2 additions & 2 deletions internal/myks/util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,9 +273,9 @@ func runCmd(name string, stdin io.Reader, args []string, logFn func(name string,
func msgRunCmd(purpose string, cmd string, args []string) string {
msg := cmd + " " + strings.Join(reductSecrets(args), " ")
if purpose == "" {
return "Running \u001B[34m" + cmd + "\u001B[0m\n\u001B[37m" + msg + "\u001B[0m"
return "Ran \u001B[34m" + cmd + "\u001B[0m\n\u001B[37m" + msg + "\u001B[0m"
} else {
return "Running \u001B[34m" + cmd + "\u001B[0m to: \u001B[3m" + purpose + "\u001B[0m\n\u001B[37m" + msg + "\u001B[0m"
return "Ran \u001B[34m" + cmd + "\u001B[0m to: \u001B[3m" + purpose + "\u001B[0m\n\u001B[37m" + msg + "\u001B[0m"
}
}

Expand Down
Loading