Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use globe config everwhere #192

Merged
merged 9 commits into from
Dec 27, 2023
Merged

refactor: use globe config everwhere #192

merged 9 commits into from
Dec 27, 2023

Conversation

kbudde
Copy link
Member

@kbudde kbudde commented Dec 27, 2023

I've noticed that we are copying constants (folder names) onto too many places.
This MR just ensures that the globe constants are used everywhere.

A good next step would be to centralize filepath.Join with our patterns.

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (4a3becc) 48.16% compared to head (4a59fb2) 48.05%.
Report is 5 commits behind head on dev.

Files Patch % Lines
internal/myks/plugins.go 0.00% 21 Missing ⚠️
internal/myks/environment.go 33.33% 2 Missing ⚠️
cmd/root.go 0.00% 1 Missing ⚠️
internal/myks/bootstrap.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #192      +/-   ##
==========================================
- Coverage   48.16%   48.05%   -0.11%     
==========================================
  Files          26       26              
  Lines        2448     2466      +18     
==========================================
+ Hits         1179     1185       +6     
- Misses       1085     1097      +12     
  Partials      184      184              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Zebradil Zebradil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

One question: is there some logic behind the order of Globe's fields? Earlier, fields were sorted alphabetically inside their groups. Now, how do I select a proper position for a new field?

internal/myks/globe.go Outdated Show resolved Hide resolved
Co-authored-by: German Lashevich <[email protected]>
@kbudde
Copy link
Member Author

kbudde commented Dec 27, 2023

Nice 👍

One question: is there some logic behind the order of Globe's fields? Earlier, fields were sorted alphabetically inside their groups. Now, how do I select a proper position for a new field?

I tried to arrange in different groups. I will do a bit more refactoring in small batches to add more order 😀

@kbudde kbudde merged commit d802cd6 into dev Dec 27, 2023
6 checks passed
@kbudde kbudde deleted the refactor_filepath_1 branch December 27, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants