-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use globe config everwhere #192
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #192 +/- ##
==========================================
- Coverage 48.16% 48.05% -0.11%
==========================================
Files 26 26
Lines 2448 2466 +18
==========================================
+ Hits 1179 1185 +6
- Misses 1085 1097 +12
Partials 184 184 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
One question: is there some logic behind the order of Globe's fields? Earlier, fields were sorted alphabetically inside their groups. Now, how do I select a proper position for a new field?
Co-authored-by: German Lashevich <[email protected]>
I tried to arrange in different groups. I will do a bit more refactoring in small batches to add more order 😀 |
I've noticed that we are copying constants (folder names) onto too many places.
This MR just ensures that the globe constants are used everywhere.
A good next step would be to centralize filepath.Join with our patterns.