Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(smart_mode): add static files directory #193

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

kbudde
Copy link
Member

@kbudde kbudde commented Dec 27, 2023

review after #192

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (4a3becc) 48.16% compared to head (8db47ab) 48.07%.
Report is 6 commits behind head on dev.

Files Patch % Lines
internal/myks/plugins.go 0.00% 21 Missing ⚠️
internal/myks/environment.go 33.33% 2 Missing ⚠️
cmd/root.go 0.00% 1 Missing ⚠️
internal/myks/bootstrap.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #193      +/-   ##
==========================================
- Coverage   48.16%   48.07%   -0.09%     
==========================================
  Files          26       26              
  Lines        2448     2467      +19     
==========================================
+ Hits         1179     1186       +7     
- Misses       1085     1097      +12     
  Partials      184      184              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Zebradil Zebradil changed the base branch from dev to refactor_filepath_1 December 27, 2023 12:21
@Zebradil Zebradil changed the base branch from refactor_filepath_1 to dev December 27, 2023 12:23
@kbudde kbudde force-pushed the fix_smart_mode_static_file branch from 4e21610 to 8db47ab Compare December 27, 2023 13:29
@Zebradil Zebradil merged commit 3f52709 into dev Dec 27, 2023
6 checks passed
@Zebradil Zebradil deleted the fix_smart_mode_static_file branch December 27, 2023 14:02
mykso-bot added a commit that referenced this pull request Dec 29, 2023
# [3.1.0](v3.0.4...v3.1.0) (2023-12-29)

### Bug Fixes

* **deps:** update golang.org/x/exp digest to 02704c9 ([#160](#160)) ([e9fe05e](e9fe05e))
* **plugins:** improve logging ([#190](#190)) ([ba31a3b](ba31a3b))
* **smart_mode:** add static files directory ([#193](#193)) ([3f52709](3f52709))

### Features

* Execute helm dependency build ([#154](#154)) ([c2c0baa](c2c0baa)), closes [#146](#146)
mykso-bot added a commit that referenced this pull request Dec 29, 2023
# [3.1.0](v3.0.4...v3.1.0) (2023-12-29)

### Bug Fixes

* **deps:** update golang.org/x/exp digest to 02704c9 ([#160](#160)) ([e9fe05e](e9fe05e))
* **plugins:** improve logging ([#190](#190)) ([ba31a3b](ba31a3b))
* **smart_mode:** add static files directory ([#193](#193)) ([3f52709](3f52709))

### Features

* Execute helm dependency build ([#154](#154)) ([c2c0baa](c2c0baa)), closes [#146](#146)
mykso-bot added a commit that referenced this pull request Dec 29, 2023
# [3.1.0](v3.0.4...v3.1.0) (2023-12-29)

### Bug Fixes

* **deps:** update golang.org/x/exp digest to 02704c9 ([#160](#160)) ([e9fe05e](e9fe05e))
* **plugins:** improve logging ([#190](#190)) ([ba31a3b](ba31a3b))
* **smart_mode:** add static files directory ([#193](#193)) ([3f52709](3f52709))

### Features

* Execute helm dependency build ([#154](#154)) ([c2c0baa](c2c0baa)), closes [#146](#146)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants