Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
farm position functionality #760
farm position functionality #760
Changes from all commits
4ad9758
b4c924c
667c19a
8348f52
5d2d020
5e05e32
4f6bbd3
97b52fa
6b47ab3
6502c5b
b70b0de
8997f70
d37f593
872278b
6580dba
3c4ffe1
5d7a848
b445da1
e46c4d2
ea612c1
9bdf09c
07f41a3
14baa0a
63de49e
0e7141c
f40d64a
ff3f040
f1496d5
98aa836
f371569
5b00a9c
4ff1b8a
00dc45d
0f87499
249c3ee
4b4e0b7
c044821
16576f1
3fc935a
be142a3
a77b760
3fe300e
37c9ebc
9859e47
d9fd841
65930ce
ee6644c
1e9ec92
bbff637
c609e42
8ac9c19
4303c0c
767f452
8100d57
aba2e4e
1d92432
494b301
772779a
d790945
0ee2b42
4262fa1
a6e3e00
36be963
ff4f6b1
5acf5e4
d1a9e72
75eba99
2e36524
67a7d42
4dc0203
3cf4458
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add empty line before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting attributes a second time, first time on line 204. Why not give them as argument?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use
decrease_user_farm_position
in other contexts (i.e.BaseExitFarmModule
).I think the improvement here would be less than the expense in
exit_farm_base
: we would have to getfarm_token
from storage and thenget_token_attributes
.This file was deleted.