farm position functionality #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasurobert
reviewed
Aug 15, 2023
|
Contract comparison - from 711aede to 3cf4458
|
dorin-iancu
reviewed
Aug 29, 2023
Comment on lines
+233
to
+235
| let farm_token_mapper = sc.farm_token(); | ||
| let token_attributes: FarmTokenAttributes<<Self::FarmSc as ContractBase>::Api> = | ||
| farm_token_mapper.get_token_attributes(farm_position.token_nonce); |
There was a problem hiding this comment.
Getting attributes a second time, first time on line 204. Why not give them as argument?
There was a problem hiding this comment.
We use decrease_user_farm_position in other contexts (i.e. BaseExitFarmModule).
I think the improvement here would be less than the expense in exit_farm_base: we would have to get farm_token from storage and then get_token_attributes.
dorin-iancu
reviewed
Aug 30, 2023
claim boosted in merge endpoints
remove exit amount parameter from farms
Moved try_set_farm_position_migration_nonce to common modules to remove code duplication.
audit fixes (2)
farm position functionality tests
farm position first audit fixes
CostinCarabas
approved these changes
Sep 29, 2023
sasurobert
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
claimBoostedRewardsendpoint, which allows any user to claim the boosted rewards for himself or for another user