Implement support for daita with multihop #7230
Conversation
Pururun
changed the title
Pururun
force-pushed
the
implement-support-for-daita-with-multihop-droid-1412
branch
3 times, most recently
from
0e5b01b to
46879ea
Compare
There was a problem hiding this comment.
Reviewed 30 of 93 files at r1, 36 of 59 files at r2, 1 of 61 files at r4.
Reviewable status: 30 of 111 files reviewed, 2 unresolved discussions (waiting on @Pururun)
android/lib/daemon-grpc/src/main/kotlin/net/mullvad/mullvadvpn/lib/daemon/grpc/ManagementService.kt line 512 at r2 (raw file):
.mapEmpty() suspend fun setDaitaEnabled(enabled: Boolean): Either<SetDaitaSettingsError, Unit> =
Should we use this message instead?
rpc SetEnableDaita(google.protobuf.BoolValue) returns (google.protobuf.Empty) {}
android/lib/daemon-grpc/src/main/kotlin/net/mullvad/mullvadvpn/lib/daemon/grpc/ManagementService.kt line 521 at r2 (raw file):
.mapEmpty() suspend fun setDaitaDirectOnly(enabled: Boolean): Either<SetDaitaSettingsError, Unit> =
Should we use this message instead?
rpc SetDaitaDirectOnly(google.protobuf.BoolValue) returns (google.protobuf.Empty) {}
Pururun
force-pushed
the
implement-multihop-ui-droid-822
branch
2 times, most recently
from
e4c6847 to
ffde559
Compare
Pururun
force-pushed
the
implement-support-for-daita-with-multihop-droid-1412
branch
from
46879ea to
b5ae47b
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 111 files reviewed, 2 unresolved discussions (waiting on @Rawa)
android/lib/daemon-grpc/src/main/kotlin/net/mullvad/mullvadvpn/lib/daemon/grpc/ManagementService.kt line 512 at r2 (raw file):
Previously, Rawa (David Göransson) wrote…
Should we use this message instead?
rpc SetEnableDaita(google.protobuf.BoolValue) returns (google.protobuf.Empty) {}
Done.
android/lib/daemon-grpc/src/main/kotlin/net/mullvad/mullvadvpn/lib/daemon/grpc/ManagementService.kt line 521 at r2 (raw file):
Previously, Rawa (David Göransson) wrote…
Should we use this message instead?
rpc SetDaitaDirectOnly(google.protobuf.BoolValue) returns (google.protobuf.Empty) {}
Done.
| DaitaScreen( | ||
| state = state, | ||
| onDaitaEnabled = viewModel::setDaita, | ||
| onDirectOnly = { enable -> |
| @@ -33,7 +34,7 @@ class FilterCustomListsRelayItemUseCase( | |||
| providers = selectedProviders, | |||
| daita = | |||
| shouldFilterByDaita( | |||
| isDaitaEnabled = settings?.isDaitaEnabled() == true, | |||
| isDaitaEnabled = settings?.daitaAndDirectOnly() == true, | |||
There was a problem hiding this comment.
Should this be more explicit? isDaitaEnabled is seemingly from this logic specifically isDirectOnlyDaitaEnabled?
Pururun
force-pushed
the
implement-support-for-daita-with-multihop-droid-1412
branch
from
b5ae47b to
477c4ea
Compare
There was a problem hiding this comment.
Reviewed 31 of 61 files at r4, 44 of 56 files at r5, 28 of 31 files at r6, 9 of 9 files at r7, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Reviewable status:
Pururun
force-pushed
the
implement-support-for-daita-with-multihop-droid-1412
branch
from
f8c699a to
d09006e
Compare
Pururun
force-pushed
the
implement-support-for-daita-with-multihop-droid-1412
branch
from
d09006e to
124bf64
Compare
Pururun
deleted the
implement-support-for-daita-with-multihop-droid-1412
branch
This change is