Replace primary container color with primary with alpha #5216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DROID-378 Replace primaryContainer with primary with alpha
We should not have theme colors with alpha |
Closed
Pururun
force-pushed
the
replace-primarycontainer-with-primary-with-alpha-droid-378
branch
from
eb653c4 to
8d9b7d5
Compare
albin-mullvad
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
Pururun
force-pushed
the
replace-primarycontainer-with-primary-with-alpha-droid-378
branch
from
8d9b7d5 to
22cfd9d
Compare
Rawa
reviewed
Oct 2, 2023
There was a problem hiding this comment.
If possible I think we should avoid the alpha in the design, it has a bunch of unforeseen consequences, but for now the design is what it is so maybe we have to settle until it changes?
Reviewable status:
albin-mullvad
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
Yes, I agree, but let's revisit that later
Reviewable status:
Pururun
force-pushed
the
replace-primarycontainer-with-primary-with-alpha-droid-378
branch
from
22cfd9d to
cab27ae
Compare
Pururun
force-pushed
the
replace-primarycontainer-with-primary-with-alpha-droid-378
branch
from
cab27ae to
3bde5a6
Compare
Pururun
deleted the
replace-primarycontainer-with-primary-with-alpha-droid-378
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the design system overhaul.
This change is