Design system PR 1 #5210
Design system PR 1 #5210
Conversation
- Set default theme as dark instead of light - Move to a color token system instead of colors in the theme - Replace some theme colors with alpha with normal colors - Remove some usage of color resource
There was a problem hiding this comment.
Reviewable status: 0 of 10 files reviewed, 3 unresolved discussions (waiting on @Pururun)
android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/cell/RelayLocationCell.kt line 172 at r1 (raw file):
relay.type == RelayItemType.City -> MaterialTheme.colorScheme.primary .copy(alpha = Alpha40)
I believe this is some transition step, but long we should look into avoiding all these Alpha's together. Maybe the result of
.copy(alpha = Alpha40)
.compositeOver(MaterialTheme.colorScheme.background)
Is a candidate of being the Secondary color?
android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/dialog/DeviceRemovalDialog.kt line 112 at r1 (raw file):
ButtonDefaults.buttonColors( containerColor = MaterialTheme.colorScheme.primary, contentColor = MaterialTheme.colorScheme.onPrimary
This looks so nice 🤩
android/lib/theme/src/main/kotlin/net/mullvad/mullvadvpn/lib/theme/Theme.kt line 73 at r1 (raw file):
//scrim = md_theme_dark_scrim, )
Idea is to slowly transition there all over?
There was a problem hiding this comment.
Nice work! 🤩
Reviewable status: 0 of 10 files reviewed, 3 unresolved discussions (waiting on @Pururun)
There was a problem hiding this comment.
Reviewed 9 of 10 files at r1, all commit messages.
Reviewable status: 9 of 10 files reviewed, 2 unresolved discussions (waiting on @Pururun)
android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/dialog/DeviceRemovalDialog.kt line 112 at r1 (raw file):
Previously, Rawa (David Göransson) wrote…
This looks so nice 🤩
Indeed! 😄 👍
There was a problem hiding this comment.
Reviewable status: 9 of 10 files reviewed, 2 unresolved discussions (waiting on @Rawa)
android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/cell/RelayLocationCell.kt line 172 at r1 (raw file):
Previously, Rawa (David Göransson) wrote…
I believe this is some transition step, but long we should look into avoiding all these Alpha's together. Maybe the result of
.copy(alpha = Alpha40) .compositeOver(MaterialTheme.colorScheme.background)Is a candidate of being the Secondary color?
Yes will add compositeOver.
android/lib/theme/src/main/kotlin/net/mullvad/mullvadvpn/lib/theme/Theme.kt line 73 at r1 (raw file):
Previously, Rawa (David Göransson) wrote…
Idea is to slowly transition there all over?
Yes the idea is to take a few colors at a time.
There was a problem hiding this comment.
Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Rawa)
This change is