Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all remaining color resource with theme colors #5215

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

Pururun
Copy link
Contributor

@Pururun Pururun commented Oct 1, 2023

This is part of the design system overhaul.

This change is Reviewable

@Pururun Pururun added the Android Issues related to Android label Oct 1, 2023
@Pururun Pururun requested a review from Rawa October 1, 2023 20:13
@linear
Copy link

linear bot commented Oct 1, 2023

DROID-377 Replace colorResource with theme colors

Remove all remaining colorResource calls with theme colors

@Pururun Pururun mentioned this pull request Oct 1, 2023
Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Pururun Pururun merged commit 3bf2f57 into main Oct 2, 2023
12 checks passed
@Pururun Pururun deleted the replace-colorresource-with-theme-colors-droid-377 branch October 2, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants