[docs] Make overview demo work in codesandbox #10661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-10661--material-ui-x.netlify.app/ |
Janpot
approved these changes
Oct 12, 2023
| @@ -17,9 +16,9 @@ function ProLabel({ children }) { | |||
| return ( | |||
| <Stack direction="row" spacing={0.5} component="span"> | |||
| <Tooltip title="Included in Pro package"> | |||
| <Link href="/x/introduction/licensing/#pro-plan"> | |||
| <a href="https://mui.com/x/introduction/licensing/#pro-plan"> | |||
| <span className="plan-pro" /> | |||
There was a problem hiding this comment.
I believe this class is not available in the codesandbox. To fully make the demo work in CSB, could it make sense to make a styled() component for this instead? With absolute url to the image?
Merged
|
Still a character encoding issue in the codesandbox. I believe the Had the core repo open so already pre-back-ported (😄) it mui/material-ui#39424 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #10619
Preview: https://deploy-preview-10661--material-ui-x.netlify.app/x/react-date-pickers/