-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Bump monorepo #10619
[core] Bump monorepo #10619
Conversation
Localization writing tips ✍️Seems you are updating localization 🌍 files. Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️
Deploy preview: https://deploy-preview-10619--material-ui-x.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to update the imports starting from @mui/monorepo/test/utils/...
to @mui/monorepo/packages/test-utils/src/...
to fix the build.
Of course, there is a reason why nobody bump the repo. The test utils moved to a different location 🫣 |
cc @michaldudak Seems like we have some issues around resolution of |
@alexfauquette Disable eslint rule for the failing lines maybe? |
Adding '@mui-internal/test-utils': path.resolve(
__dirname,
'./node_modules/@mui/monorepo/packages/test-utils/src',
), to webpackBaseConfig's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks everyone!
Thanks @michaldudak, I tried this earlier but my VS code eslint extension didn't read the updated config, it forced me to think it didn't work 😄 Better to check with the command line script. |
For anyone doing a lot of eslint config work, there is a command in vscode to restart the eslint server: Cmd+Shift+P then choose "ESLint: Restart ESLint Server". (And there's a similar one for typescript as well) |
Thanks everyone for the team effort on fixing those remaining lint error 🙏 |
@@ -1,4 +1,5 @@ | |||
import * as React from 'react'; | |||
import Link from 'next/link'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In theory, we would need to import from https://github.com/mui/material-ui/blob/master/docs/src/modules/components/Link.tsx to support multi language, but since we are not actively supporting Chinese, it's transparent for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be removed in a followup PR #10661
Monorepo was in v5.14.10 but the new feedback function is in v5.14.11