Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Bump monorepo #10619

Merged
merged 8 commits into from
Oct 12, 2023
Merged

[core] Bump monorepo #10619

merged 8 commits into from
Oct 12, 2023

Conversation

alexfauquette
Copy link
Member

Monorepo was in v5.14.10 but the new feedback function is in v5.14.11

@alexfauquette alexfauquette added the docs Improvements or additions to the documentation label Oct 9, 2023
@mui-bot
Copy link

mui-bot commented Oct 9, 2023

Localization writing tips ✍️

Seems you are updating localization 🌍 files.

Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️

  • Verify if the PR title respects the release format. Here are two examples (depending if you update or add a locale file)

    [l10n] Improve Swedish (sv-SE) locale
    [l10n] Add Danish (da-DK) locale

  • Update the documentation of supported locales by running yarn l10n
  • Clean files with yarn prettier.

Deploy preview: https://deploy-preview-10619--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against bead06f

Copy link
Member

@MBilalShafi MBilalShafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to update the imports starting from @mui/monorepo/test/utils/... to @mui/monorepo/packages/test-utils/src/... to fix the build.

@MBilalShafi MBilalShafi changed the title Bump monorepo [core] Bump monorepo Oct 9, 2023
@alexfauquette
Copy link
Member Author

Of course, there is a reason why nobody bump the repo. The test utils moved to a different location 🫣

mui/material-ui#39061

@alexfauquette alexfauquette added scope: code-infra Specific to the core-infra product and removed docs Improvements or additions to the documentation labels Oct 9, 2023
babel.config.js Show resolved Hide resolved
tsconfig.json Show resolved Hide resolved
@Janpot
Copy link
Member

Janpot commented Oct 12, 2023

cc @michaldudak Seems like we have some issues around resolution of @mui-internal/test-utils in eslint for two files. I'm not quite sure but it looks like in the monorepo resolution for these files happens through regular node.js package resolution. No aliasing kicking in. Not sure how we best translate this to the X repo. Any pointers?

@MBilalShafi
Copy link
Member

@alexfauquette Disable eslint rule for the failing lines maybe?
Making these files .ts seems to resolve the issue but arises more of them

@michaldudak
Copy link
Member

Adding

'@mui-internal/test-utils': path.resolve(
  __dirname,
  './node_modules/@mui/monorepo/packages/test-utils/src',
),

to webpackBaseConfig's resolve.alias should tell ESLint where to look for this package.

Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks everyone!

@MBilalShafi
Copy link
Member

Thanks @michaldudak, I tried this earlier but my VS code eslint extension didn't read the updated config, it forced me to think it didn't work 😄 Better to check with the command line script.
After restarting the VS code it updated though.

@MBilalShafi MBilalShafi merged commit 863b677 into mui:master Oct 12, 2023
5 checks passed
@Janpot
Copy link
Member

Janpot commented Oct 12, 2023

After restarting the VS code it updated though.

For anyone doing a lot of eslint config work, there is a command in vscode to restart the eslint server: Cmd+Shift+P then choose "ESLint: Restart ESLint Server". (And there's a similar one for typescript as well)

@alexfauquette
Copy link
Member Author

Thanks everyone for the team effort on fixing those remaining lint error 🙏

@@ -1,4 +1,5 @@
import * as React from 'react';
import Link from 'next/link';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory, we would need to import from https://github.com/mui/material-ui/blob/master/docs/src/modules/components/Link.tsx to support multi language, but since we are not actively supporting Chinese, it's transparent for now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be removed in a followup PR #10661

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: code-infra Specific to the core-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants