Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][Accordion] Deprecate *Props props and classes for v6 #40418

Merged
merged 11 commits into from
Jan 16, 2024

Conversation

DiegoAndai
Copy link
Member

@DiegoAndai DiegoAndai commented Jan 3, 2024

Part of: #40417

Review accordion-related components:

  • Accordion: Add deprecations for transition props and the slots API that should replace it.
  • AccordionActions: No changes
  • AccordionDetails: No changes
  • AccordionSummary: Deprecate contentGutters class

Because this is the first deprecations PR, it also adds slot pattern utils developed for Joy UI. This is done as the slots pattern will replace the *Props and *Component type props.

Questions for reviewers

  • I took the slot utils from Joy with minor modifications. Something I'm unsure about is the following: Joy's useSlot adds common slot props component and sx. I kept this as it applies to Material UI, but I was unsure whether to do it.
  • I left more questions in the code.
  • Are there any other deprecations we should add to these components?

@DiegoAndai DiegoAndai added component: accordion This is the name of the generic UI component, not the React module! v6.x labels Jan 3, 2024
@DiegoAndai DiegoAndai self-assigned this Jan 3, 2024
@mui-bot
Copy link

mui-bot commented Jan 3, 2024

Netlify deploy preview

@material-ui/core: parsed: +0.19% , gzip: +0.28%

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 793c4b1

@danilo-leal danilo-leal added the package: material-ui Specific to @mui/material label Jan 4, 2024
@DiegoAndai DiegoAndai force-pushed the accordion-v6-deprecations branch from 6a4973a to 549b303 Compare January 5, 2024 14:13
@DiegoAndai DiegoAndai changed the title [material-ui][Accordion] Deprecate transition props and add slots API [material-ui][Accordion] Deprecate props and classes for v6 Jan 5, 2024
@DiegoAndai DiegoAndai force-pushed the accordion-v6-deprecations branch from 8cbfe00 to a520781 Compare January 5, 2024 17:42
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 8, 2024
@DiegoAndai DiegoAndai force-pushed the accordion-v6-deprecations branch from a520781 to 3ba8004 Compare January 9, 2024 18:57
@DiegoAndai DiegoAndai force-pushed the accordion-v6-deprecations branch from af5da3e to 9415fb9 Compare January 11, 2024 17:57
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 11, 2024
@DiegoAndai DiegoAndai marked this pull request as ready for review January 12, 2024 00:52
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. I left few comments for consideration. I would recommend chane the title to: "[material-ui][Accordion] Deprecate *Props props and classes for v6" and scope the changes to only these in all components. If we see other thins for deprecation we could be opening separate pull requests (in case if we find issues it would be easier to revert).

packages/mui-material/src/Accordion/Accordion.d.ts Outdated Show resolved Hide resolved
@DiegoAndai DiegoAndai changed the title [material-ui][Accordion] Deprecate props and classes for v6 [material-ui][Accordion] Deprecate *Props props and classes for v6 Jan 15, 2024
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: accordion This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material v6.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants