-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui][Accordion] Deprecate *Props props and classes for v6 #40418
Conversation
Netlify deploy preview@material-ui/core: parsed: +0.19% , gzip: +0.28% Bundle size reportDetails of bundle changes (Toolpad) |
6a4973a
to
549b303
Compare
8cbfe00
to
a520781
Compare
a520781
to
3ba8004
Compare
af5da3e
to
9415fb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. I left few comments for consideration. I would recommend chane the title to: "[material-ui][Accordion] Deprecate *Props props and classes for v6" and scope the changes to only these in all components. If we see other thins for deprecation we could be opening separate pull requests (in case if we find issues it would be easier to revert).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 Awesome!
Part of: #40417
Review accordion-related components:
Because this is the first deprecations PR, it also adds slot pattern utils developed for Joy UI. This is done as the slots pattern will replace the *Props and *Component type props.
Questions for reviewers
component
andsx
. I kept this as it applies to Material UI, but I was unsure whether to do it.