-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs-infra] Improve API page deprecation info #40440
[docs-infra] Improve API page deprecation info #40440
Conversation
Netlify deploy previewhttps://deploy-preview-40440--material-ui.netlify.app/ Bundle size report |
What about splitting the information "there is a deprecation" with @michaldudak Could you confirm it's what you intended to do in your refacto of this script? |
We need translated text in the translations JSON for sure. |
40af114
to
d065376
Compare
@alexfauquette @danilo-leal, this is ready for your re-review 😊 I updated the description with the added changes. I didn't know how to figure out why the MUI X deprecation warnings in their API pages didn't update. I thought these were shared. |
Effectively the X docs is depending on the core one. So after merging this PR X will be able to update it's dependency to the monorepo and the get the update 👍 I made a try using your branch, but seems you don't have deprecated classes, nothing change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sound very nice. Especially having a single component for warnings 🙏
Could you update the #40418 to be able to see the components with their last version of the modification?
Done 😊: https://deploy-preview-40418--material-ui.netlify.app/material-ui/api/accordion-summary/#classes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome! 🤙
Summary
Details of each are below
Standardize API page alert
Introduce the
ApiWarning
component to standardize all API page warning alerts: deprecations and "needs to be able to hold a ref" alerts on both table and list views.This doesn't include other warnings throughout the docs, which might be something we should look into but goes beyond the scope of this PR.
Add "DEPRECATED" label to props and class lists
This indicates deprecations when lists are collapsed. Without this change, deprecations cannot be seen until the prop is expanded.
Add support for class deprecation in API docs:
This is required, for example, for #40418. Here's an example of how it would look like.
Notes
This is my first docs-infra PR, so please correct anything I might not be aware of 😊.