[core] Simplify docs feedback interaction #39075
Conversation
Netlify deploy previewhttps://deploy-preview-39075--material-ui.netlify.app/ Bundle size report |
| type: 'plain_text', | ||
| text: 'Save', | ||
| }, | ||
| action_id: 'save_message', |
There was a problem hiding this comment.
I feel I will stop using this action. But it sounds fair to keep both, at the very least for the sake of continuity & experimenting with GitHub issues.
alexfauquette
requested review from
oliviertassinari,
Janpot and
michaldudak
Co-authored-by: Jan Potoms <[email protected]> Signed-off-by: Alexandre Fauquette <[email protected]>
| message, | ||
| } = body; | ||
|
|
||
| const { quote, links } = getQuoteAndLinks(message); |
There was a problem hiding this comment.
Just a suggestion, but I quickly skimmed this doc
I may be misunderstanding it, but it looks like you can specify a value to pass along as payload when clicking the delete button. If so, that could offer a more structured way of passing along this information?
There was a problem hiding this comment.
I did not use it because it only accepts a string and I need multiple values.
But now I see it could be used with JSON.stringify({ quote, links }) and JSON.parse
There was a problem hiding this comment.
Looks good to me, I added one suggestion where you could look into to improve a bit passing data from the original slack message to the delete action. I could be wrong though. If you feel like looking deeper into it, happy to rereview your changes, otherwise good to merge.
Co-authored-by: Olivier Tassinari <[email protected]> Signed-off-by: Alexandre Fauquette <[email protected]>
Co-authored-by: Jan Potoms <[email protected]> Co-authored-by: Olivier Tassinari <[email protected]>
The goal is to add actions directly into messages, such that with a single click, you can: