[test] Split the test package #39061
Conversation
michaldudak
force-pushed
the
split-test-package
branch
from
a629632 to
5531c65
Compare
Netlify deploy previewhttps://deploy-preview-39061--material-ui.netlify.app/ Bundle size report |
| @@ -211,15 +211,6 @@ module.exports = { | |||
| rules: { | |||
| // does not work with wildcard imports. Mistakes will throw at runtime anyway | |||
| 'import/named': 'off', | |||
| 'no-restricted-imports': [ | |||
There was a problem hiding this comment.
No need to do this anymore as package.json's export field controls visibility of exports.
There was a problem hiding this comment.
Which linting process is now controlling this? The typescript type checker?
There was a problem hiding this comment.
Node doesn't allow importing arbitrary files from the package when any subpath exports are defined.
There was a problem hiding this comment.
Ok, 👍 that assumes there is at least one Node.js process importing this natively
| "noUnusedLocals": true, | ||
| "skipLibCheck": true, | ||
| "esModuleInterop": true | ||
| "esModuleInterop": true, | ||
| "moduleResolution": "node16", |
There was a problem hiding this comment.
This lets TS respect the exports field in other packages (making adding the new package to root tsconfig's paths unnecessary).
github-actions
bot
added
the
PR: out-of-date
There was a problem hiding this comment.
Ok, so as a first step it's getting all the imports in order without really touching the implementation. So if I understand correctly, the only cycle that is really left is one between test and @mui/test-utilities? Which will be tackled separately? (I really like this style of development, especially for code infra stuff which often touches a lot of code, makes things much easier to review)
If I had to nit about one thing it'd be about nomenclature. Across the codebases we tend to name these packages/folders "utils" not "utilities".
No, there's no cycle between them. The ones remaining are between [@mui/material, @mui/base, @mui/joy] and @mui-internal/test-utilities as the describeConformance utilities use components from these packages. I'll open a separate PR for this as it requires some code changes.
Actually, I named this package after |
github-actions
bot
removed
the
PR: out-of-date
This is a step towards removing circular package dependencies.
This PR splits the
testpackage into two:@mui-internal/test-utils(that live under the packages directory) and@mui-internal/tests(which remains under the test directory).@mui-internal/test-utilscontains the files from the old test/utils directory.I renamed the remains to
@mui-internal/tests, astestis the name of Node's built-in package.This PR does not remove the actual dependency cycles. It requires refactoring of several modules under test-utils. I'll open a separate PR for this.