Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Open demo crash in the right repository #39006

Merged
merged 3 commits into from
Sep 18, 2023

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Sep 16, 2023

I have seen enough of it https://github.com/mui/mui-x/issues?q=is%3Aissue+demo+crashes+is%3Aclosed+

Screenshot 2023-09-16 at 17 12 18 Screenshot 2023-09-16 at 17 12 40 Screenshot 2023-09-16 at 17 13 19 Screenshot 2023-09-16 at 17 13 04 Screenshot 2023-09-16 at 17 15 25 Screenshot 2023-09-16 at 17 12 33

I'm stepping in 😁, transferring issues takes time, so let's have developers open the issue in the right repository instead.

I changed a bit the UI as well, it looks like this:

Screenshot 2023-09-16 at 17 31 07

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work scope: docs-infra Specific to the docs-infra product labels Sep 16, 2023
@mui-bot
Copy link

mui-bot commented Sep 16, 2023

Netlify deploy preview

https://deploy-preview-39006--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against c152565

Copy link
Member

@michelengelen michelengelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great improvement ... just nits that possibly come from eslint or prettier formatting! 💯

docs/src/modules/components/DemoErrorBoundary.js Outdated Show resolved Hide resolved
Comment on lines +45 to +47
- [ ] I have [searched for similar issues](${
process.env.SOURCE_CODE_REPO
}/issues?q=${searchQuery}) in this repository and believe that this is not a duplicate.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [ ] I have [searched for similar issues](${
process.env.SOURCE_CODE_REPO
}/issues?q=${searchQuery}) in this repository and believe that this is not a duplicate.
- [ ] I have [searched for similar issues](${process.env.SOURCE_CODE_REPO}/issues?q=${searchQuery}) in this repository and believe that this is not a duplicate.

Copy link
Member Author

@oliviertassinari oliviertassinari Sep 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prettier, we have disabled most eslint rules about formating.

@oliviertassinari oliviertassinari enabled auto-merge (squash) September 18, 2023 18:39
@oliviertassinari oliviertassinari merged commit 3d3ed70 into mui:master Sep 18, 2023
5 checks passed
@oliviertassinari oliviertassinari deleted the docs-infra-wrong-repo branch September 18, 2023 19:45
danilo-leal pushed a commit to siriwatknp/material-ui that referenced this pull request Sep 18, 2023
christophermorin pushed a commit to christophermorin/material-ui that referenced this pull request Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants