-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs-infra] Open demo crash in the right repository #39006
[docs-infra] Open demo crash in the right repository #39006
Conversation
Netlify deploy previewhttps://deploy-preview-39006--material-ui.netlify.app/ Bundle size report |
29aad1d
to
9af5798
Compare
9af5798
to
5f62b10
Compare
9696676
to
986b9f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great improvement ... just nits that possibly come from eslint
or prettier
formatting! 💯
- [ ] I have [searched for similar issues](${ | ||
process.env.SOURCE_CODE_REPO | ||
}/issues?q=${searchQuery}) in this repository and believe that this is not a duplicate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- [ ] I have [searched for similar issues](${ | |
process.env.SOURCE_CODE_REPO | |
}/issues?q=${searchQuery}) in this repository and believe that this is not a duplicate. | |
- [ ] I have [searched for similar issues](${process.env.SOURCE_CODE_REPO}/issues?q=${searchQuery}) in this repository and believe that this is not a duplicate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prettier, we have disabled most eslint rules about formating.
I have seen enough of it https://github.com/mui/mui-x/issues?q=is%3Aissue+demo+crashes+is%3Aclosed+
I'm stepping in 😁, transferring issues takes time, so let's have developers open the issue in the right repository instead.
I changed a bit the UI as well, it looks like this: