[docs][joy-ui] Integrate a count-up feature to the Circular Progress #38724
Conversation
Netlify deploy previewBundle size report |
xcode-it
changed the title
zannager
added
docs
docs/data/joy/components/circular-progress/circular-progress.md
Outdated
Show resolved
Hide resolved
docs/data/joy/components/circular-progress/circular-progress.md
Outdated
Show resolved
Hide resolved
docs/data/joy/components/circular-progress/circular-progress.md
Outdated
Show resolved
Hide resolved
| ## Common examples | ||
|
|
||
| ### Count up feature |
There was a problem hiding this comment.
| ## Common examples | |
| ### Count up feature | |
| ## 3rd-party integration | |
| ### use-count-up |
@danilo-leal What do you think about grouping 3rd-party libraries in h2?
We have a similar thing on input but it is h3.
There was a problem hiding this comment.
I think I'd still leave it in the Common examples, as it would be more consistent with the Input. Maybe the "Third-party integration" title works but it isn't immediately clear when compared to "Third-party formatting" (Input's case). 🤔
| import CircularProgress from '@mui/joy/CircularProgress'; | ||
| import Stack from '@mui/joy/Stack'; | ||
| import Typography from '@mui/joy/Typography'; | ||
| import * as React from 'react'; |
There was a problem hiding this comment.
Can you move React import to the top for codebase consistency?
| import Stack from '@mui/joy/Stack'; | ||
| import Typography from '@mui/joy/Typography'; | ||
| import * as React from 'react'; | ||
| import { useCountUp } from 'use-count-up'; |
There was a problem hiding this comment.
Please add use-count-up to docs/package.json, then run yarn install.
|
Not sure why this is close. |
branch renamed to circular-progress-count-up-feature Not familiar with the process of creating PR's. As it's my first PR ever, and still learning... a bit confusing. |
Closes #38682