-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][joy-ui] Add count-up integration demo to Circular Progress #38682
Comments
Hey there @anon-phantom, thanks for opening the issue! Would a section on the documentation suffice to point out the integration? I'm not sure if we should include any of these as a dependency of the library, but it seems something we could at least demonstrate in the docs how to do it, taking into consideration the options you provided! What do you think? |
Yes, it would. The method provided in For example, if you mapped a value greater than condesandbox updated to accept multiple values. |
@anon-phantom I'm with @danilo-leal, this could be easily achieved with a simple hook. I think that this use case is a very specific one and thus considering to have it built in shouldn't be the path to proceed. But that is my personal opinion. |
Cool, that's great! Well, @anon-phantom & @marcpachecog feel free to propose a PR with these doc additions + demos to demonstrate them! Make sure you tag @siriwatknp & @zanivan for a review both for the technical and design side! 🤙 |
created a new PR |
Agree with @marcpachecog, adding a integration demo should be sufficient. |
Duplicates
Related page
https://mui.com/joy-ui/react-circular-progress/
Kind of issue
Other
Issue description
It would be nice to integrate count-up functionality to circular progress using either one of the following packages:
codesandbox
2023-08-28_13-30-27.mp4
Context 🔦
No response
The text was updated successfully, but these errors were encountered: