Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][joy-ui] Add count-up integration demo to Circular Progress #38682

Closed
1 task done
xcode-it opened this issue Aug 28, 2023 · 6 comments · Fixed by #38952
Closed
1 task done

[docs][joy-ui] Add count-up integration demo to Circular Progress #38682

xcode-it opened this issue Aug 28, 2023 · 6 comments · Fixed by #38952
Assignees
Labels
component: CircularProgress The React component docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy

Comments

@xcode-it
Copy link
Contributor

Duplicates

  • I have searched the existing issues

Related page

https://mui.com/joy-ui/react-circular-progress/

Kind of issue

Other

Issue description

It would be nice to integrate count-up functionality to circular progress using either one of the following packages:

codesandbox

2023-08-28_13-30-27.mp4

Context 🔦

No response

@xcode-it xcode-it added status: waiting for maintainer These issues haven't been looked at yet by a maintainer support: docs-feedback Feedback from documentation page labels Aug 28, 2023
@xcode-it xcode-it changed the title Suggestion [joy-ui] Suggestion Aug 28, 2023
@danilo-leal danilo-leal changed the title [joy-ui] Suggestion [joy-ui] Integrate a count-up feature to the Circular Progress Aug 28, 2023
@danilo-leal danilo-leal added new feature New feature or request component: CircularProgress The React component package: joy-ui Specific to @mui/joy and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer support: docs-feedback Feedback from documentation page labels Aug 28, 2023
@danilo-leal
Copy link
Contributor

Hey there @anon-phantom, thanks for opening the issue! Would a section on the documentation suffice to point out the integration? I'm not sure if we should include any of these as a dependency of the library, but it seems something we could at least demonstrate in the docs how to do it, taking into consideration the options you provided! What do you think?

@xcode-it
Copy link
Contributor Author

xcode-it commented Aug 29, 2023

Yes, it would.

The method provided in codsandbox might be inconvenient in some cases, but I'm sure there's a workaround...

For example, if you mapped a value greater than 100

condesandbox updated to accept multiple values.

@marcpachecog
Copy link

@anon-phantom I'm with @danilo-leal, this could be easily achieved with a simple hook. I think that this use case is a very specific one and thus considering to have it built in shouldn't be the path to proceed. But that is my personal opinion.

@danilo-leal
Copy link
Contributor

Cool, that's great! Well, @anon-phantom & @marcpachecog feel free to propose a PR with these doc additions + demos to demonstrate them! Make sure you tag @siriwatknp & @zanivan for a review both for the technical and design side! 🤙

xcode-it added a commit to xcode-it/material-ui that referenced this issue Aug 30, 2023
@xcode-it
Copy link
Contributor Author

created a new PR

@siriwatknp
Copy link
Member

@anon-phantom I'm with @danilo-leal, this could be easily achieved with a simple hook. I think that this use case is a very specific one and thus considering to have it built in shouldn't be the path to proceed. But that is my personal opinion.

Agree with @marcpachecog, adding a integration demo should be sufficient.

@siriwatknp siriwatknp changed the title [joy-ui] Integrate a count-up feature to the Circular Progress [docs][joy-ui] Integrate a count-up feature to the Circular Progress Sep 12, 2023
@siriwatknp siriwatknp changed the title [docs][joy-ui] Integrate a count-up feature to the Circular Progress [docs][joy-ui] Add count-up integration demo to Circular Progress Sep 12, 2023
@siriwatknp siriwatknp added docs Improvements or additions to the documentation and removed new feature New feature or request labels Sep 12, 2023
@danilo-leal danilo-leal moved this from Future to In progress now in Joy UI Sep 13, 2023
@github-project-automation github-project-automation bot moved this from In progress now to Recently completed in Joy UI Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: CircularProgress The React component docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy
Projects
Status: Recently completed
5 participants