Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Add Charts to the pricing table #38680

Merged
merged 14 commits into from
Oct 2, 2023

Conversation

alexfauquette
Copy link
Member

@alexfauquette alexfauquette commented Aug 28, 2023

This is the first pricing for charts, to answer questions such as mui/mui-x#10137.

I only put charts that might be developed this year.

Preview: https://deploy-preview-38680--material-ui.netlify.app/pricing/

@alexfauquette alexfauquette added website Pages that are not documentation-related, marketing-focused. component: charts labels Aug 28, 2023
@mui-bot
Copy link

mui-bot commented Aug 28, 2023

Netlify deploy preview

https://deploy-preview-38680--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 113d7db

@danilo-leal danilo-leal changed the title [docs] Add charts in pricing table [website] Add Charts to the pricing table Aug 28, 2023
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the feature split:


Maybe only one question: are we sure we already want to display these Premium features? I mean, I'm considering managing the expectations of visitors on when we will tackle these.

docs/src/components/pricing/PricingTable.tsx Outdated Show resolved Hide resolved
@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 7, 2023

From a meeting with @joserodolfofreitas, I'm not sold that we should attempt at "Advanced Gantt" or "Candlestick". These are relative niches, I think we lack data to say we will build these. Maybe a rich text editor would be a much better vertical to go into once we cover the most common Chart Pro features. So, the thought was we could either display these as greyed with a request to upvote on GitHub or not display them at all.

@alexfauquette
Copy link
Member Author

I only see one issue with not having "Advanced Gantt" in the pricing table: not informing user that some feature could be restricted to premium. But if we never develop them before year, it should be ok to add premium plan latter for them

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm excited to put this live. Let's do it 🚀

docs/src/components/pricing/PricingTable.tsx Outdated Show resolved Hide resolved
'charts/funnel': pending,
'charts/sankey': pending,
'charts/gantt': pending,
'charts/gantt-advanced': pending,
Copy link
Member

@joserodolfofreitas joserodolfofreitas Sep 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid creating the commitment to building these features in the short-medium term, we can change from "pending" to "TBD".

If possible, bellow the "TBD" text we could have something like "Interested?" as a link.
The link sends the user to a Google form where they can confirm and expand on their expectations for these premium features.
We could also consider having the TBD text itself as a link, if we see it's getting to noisy.

Suggested change
'charts/gantt-advanced': pending,
'charts/gantt-advanced': TBD,

Wdyt?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why using a Google form instead of a github issue?

Copy link
Member

@joserodolfofreitas joserodolfofreitas Sep 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe people would be more compelled to share their use cases (and it'd probably feel less intimidating for the non-technical audience), but I suppose we can also create GitHub issue and make the questions pop up on the description. It's also a good thing that we can redirect each "TBD" to a different issue.

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Heat map" is not shown on the pricing page.

docs/src/components/pricing/PricingTable.tsx Outdated Show resolved Hide resolved
docs/src/components/pricing/PricingTable.tsx Outdated Show resolved Hide resolved
Copy link
Member

@joserodolfofreitas joserodolfofreitas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the form; let's see if we get some clicks.

docs/src/components/pricing/PricingTable.tsx Outdated Show resolved Hide resolved
docs/src/components/pricing/PricingTable.tsx Outdated Show resolved Hide resolved
@alexfauquette
Copy link
Member Author

@joserodolfofreitas I think we are good with design now

image

Copy link
Member

@joserodolfofreitas joserodolfofreitas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, @alexfauquette! Thank you!
I'm happy to see this going live.

@alexfauquette alexfauquette merged commit 4f875de into mui:master Oct 2, 2023
6 checks passed
const toBeDefined = (
<Typography
component={Link}
href="https://forms.gle/19vN87eBvmXPjBVp6"
Copy link
Member

@oliviertassinari oliviertassinari Sep 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that I can't access this form (https://forms.gle/19vN87eBvmXPjBVp6).

Can we share access to this Google Form with [email protected] with write access? (or at minimum view and [email protected] with write access) Thanks.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

Copy link
Member

@oliviertassinari oliviertassinari Sep 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: charts website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants