[charts] Share upfront future Pro features #10465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
docs
| @@ -3,5 +3,5 @@ import MarkdownDocs from 'docs/src/modules/components/MarkdownDocs'; | |||
| import * as pageProps from 'docsx/data/charts/gantt/gantt.md?@mui/markdown'; | |||
|
|
|||
| export default function Page() { | |||
| return <MarkdownDocs {...pageProps} />; | |||
| return <MarkdownDocs {...pageProps} disableAd />; | |||
There was a problem hiding this comment.
We could automatically add this prop based on the header. At scale, it would be more reliable. Feels a bit overkill for now.
Netlify deploy previewNetlify deploy preview: https://deploy-preview-10465--material-ui-x.netlify.app/ Updated pagesThese are the results for the performance tests:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick PR to integrate mui/material-ui#38680. As a developer, this would be my main fear to gradually adopting this charts library, what will be MIT, what won't be.
https://deploy-preview-10465--material-ui-x.netlify.app/x/react-charts/