[docs] Number Input docs fixes #38521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mj12albert
added
docs
Netlify deploy previewBundle size report |
mj12albert
force-pushed
the
docs/number-input-docs
branch
from
e6a0d27 to
3ea9c60
Compare
oliviertassinari
changed the title
oliviertassinari
added
the
component: number field
michaldudak
reviewed
Aug 28, 2023
docs/data/base/pages.ts
Outdated
| @@ -25,7 +25,7 @@ const pages: readonly MuiPage[] = [ | |||
| { pathname: '/base-ui/react-button', title: 'Button' }, | |||
| { pathname: '/base-ui/react-checkbox', title: 'Checkbox', planned: true }, | |||
| { pathname: '/base-ui/react-input', title: 'Input' }, | |||
| { pathname: '/base-ui/react-number-input', title: 'Number Input' }, | |||
| { pathname: '/base-ui/react-number-input', title: 'Number Input', newFeature: true }, | |||
There was a problem hiding this comment.
Let's remove this and go with the solution from #38573 when it's merged.
mj12albert
force-pushed
the
docs/number-input-docs
branch
from
3ea9c60 to
fe1ffa7
Compare
michaldudak
approved these changes
Aug 29, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Sep 8, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes several issues raised in #36119 (comment)
Fixed indentation in a snippet in the Basics section
Step rounding - I've added a callout about decimals not being supported yet and linking to an issue to upvote
Preview https://deploy-preview-38521--material-ui.netlify.app/base-ui/react-number-input/