Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[base-ui][number input] Icon position issue #39273

Closed
oliviertassinari opened this issue Oct 2, 2023 · 4 comments · Fixed by #38820
Closed

[base-ui][number input] Icon position issue #39273

oliviertassinari opened this issue Oct 2, 2023 · 4 comments · Fixed by #38820
Assignees
Labels
component: number field This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer docs Improvements or additions to the documentation package: base-ui Specific to @mui/base

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Oct 2, 2023

Related to #38521

Steps to reproduce 🕹

Link to live example:

Steps:

  1. Open https://mui.com/base-ui/react-number-input/
Screen.Recording.2023-10-03.at.01.47.30.mov

Current behavior 😯

Different look & feel between different style engines

Expected behavior 🤔

Same look & feel between different style engines.

Context 🔦

I also think that we could make some design tweaks:

  • Increase the font size a bit of the arrow
  • Add more padding-right to compensate for the border-radius only on the right side
  • Move the arrow a bit closer to the horizontal middle

Current:

Screenshot 2023-10-03 at 01 56 48

After:

Screenshot 2023-10-03 at 01 56 44

Your environment 🌎

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work status: waiting for maintainer These issues haven't been looked at yet by a maintainer component: number field This is the name of the generic UI component, not the React module! labels Oct 2, 2023
@spritualrahul
Copy link

I will be happy to contribute my experience in this project and try to resolve the issue, kindly assign this issue to me.

@DARSHANITRIPATHI
Copy link

can you please assign it to me?

@Pratik1603
Copy link

Can you please assign me this issue

@guptaG1410 guptaG1410 mentioned this issue Oct 3, 2023
1 task
@mj12albert mj12albert added this to Joy UI Oct 3, 2023
@mj12albert mj12albert added docs Improvements or additions to the documentation and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Oct 3, 2023
@mj12albert mj12albert moved this to Selected in Joy UI Oct 3, 2023
@danilo-leal
Copy link
Contributor

danilo-leal commented Oct 3, 2023

@zanivan's PR linked above will tackle this if it still needs to! 🤙
PS: I removed the bug label as this isn't a functional issue but more of a design fix.

@danilo-leal danilo-leal changed the title [number input] Icon position issue [base-ui][number input] Icon position issue Oct 3, 2023
@danilo-leal danilo-leal added package: base-ui Specific to @mui/base design This is about UI or UX design, please involve a designer and removed bug 🐛 Something doesn't work labels Oct 3, 2023
@github-project-automation github-project-automation bot moved this from Selected to Recently completed in Joy UI Oct 18, 2023
@michaldudak michaldudak moved this to Done in Base UI Alpha Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: number field This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer docs Improvements or additions to the documentation package: base-ui Specific to @mui/base
Projects
Status: Recently completed
6 participants