Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "restart" and "coalesce" as allowed verbs #130

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Add "restart" and "coalesce" as allowed verbs #130

merged 1 commit into from
Mar 19, 2024

Conversation

faern
Copy link
Contributor

@faern faern commented Mar 19, 2024 •
edited
Loading

Thank you for this very handy action!

Just a few days after introducing it on our repository we had
developers requesting these two extra verbs.
I explicitly added them to our repo.
But they are not weird verbs, so I don't see any
reason why they could not be upstreamed also.

@faern faern changed the title Add "restart" and "coalesce" as whitelisted verbs Add "restart" and "coalesce" as allowed verbs Mar 19, 2024
Fryuni
Fryuni reviewed Mar 19, 2024
View reviewed changes
Copy link
Contributor

@Fryuni Fryuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mristin
Copy link
Owner

mristin commented Mar 19, 2024

@faern sorry, I edited the PR description since the CI failed only to realize that the CI works on commit messages and not on the pull request description 🤦‍♂️.

Can you please re-flow the commit message to fit 72 characters in width, with links put at the end of the message on separate lines, and referenced from the text? Finally, you have to force-push the ammended message as we check for all the commit messages in a PR.

@faern faern force-pushed the add-restart-coalesce branch from cbfd559 to bd8bf76 Compare March 19, 2024 18:56
@faern
Add "restart" and "coalesce" to list of OK verbs
b8ce871 
We extend the whitelist of the verbs.
@faern faern force-pushed the add-restart-coalesce branch from bd8bf76 to b8ce871 Compare March 19, 2024 18:58
@faern
Copy link
Contributor Author

faern commented Mar 19, 2024

The commit message is just a short oneliner... But I added a body now since it looks like you enforce that... But the failure log was about the PR description being too long lines, so I edited that also... Now it might work?

@mristin mristin merged commit 07feebb into mristin:master Mar 19, 2024
3 checks passed
@mristin
Copy link
Owner

mristin commented Mar 19, 2024

Thanks, @faern ! Merged in! Do you need a patch version?

@faern
Copy link
Contributor Author

faern commented Mar 19, 2024

We are not in a hurry since we added them as extra verbs for now. Release whenever you want to ☺️

@faern
Copy link
Contributor Author

faern commented Mar 19, 2024

Maybe we realize even more words in a few days, who knows ;)

@faern faern deleted the add-restart-coalesce branch March 20, 2024 11:47
@faern faern mentioned this pull request Mar 26, 2024
Merged
mristin pushed a commit that referenced this pull request Mar 27, 2024
@faern
Release 3.1.1 (#133)
f3b9cec 
In this release, we add a substantially more verbs.

*  Add "restart" and "coalesce" as allowed verbs #130 
*  Add more verbs scraped from another repository #131
@faern faern mentioned this pull request Jul 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fryuni Fryuni Fryuni left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@faern @mristin @Fryuni