-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'bias', 'obfuscate' and 'tidy' #140
Conversation
4d7856c
to
03b8047
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @faern !
@faern can you please fix the commit message? (See the failing CI.) |
03b8047
to
5141858
Compare
I recommited the same thing and force pushed, just to trigger the CI. Should be fine now? |
Oh, lol. It was complaining about the length of the github PR title? 😂 My god. I have been so confused about that before. Why do you enforce that to be so short? I guess that's a more ideological question. The only reason I want to limit the length of git commit messages is so they display nicely when rendered as a tree in my terminal. For the github PR title and description none of those limitations apply. |
I think I couldn't really separate the two in the code as far as I can remember. I'm open to changing that behavior -- please feel free to open a new issue! |
But we are using this CI action and only limit git commit messages, not github PR content. It just works? 🤷 😂 |
However, that is completely unrelated to this PR. Feel free to merge the extra verbs :) |
I think the event is crucial -- if you run it against pull request, the body will be the pull request description. I'm not really sure anymore, though. |
Another small batch of allowed verbs that we have ended up using since adopting this CI check! Following in the footsteps of #130 and #131 :)