Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement Google EU Consent #171

Merged
merged 4 commits into from
Sep 11, 2024
Merged

feat: Implement Google EU Consent #171

merged 4 commits into from
Sep 11, 2024

Conversation

Mansi-mParticle
Copy link
Contributor

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Implemented Google EU Consent for Braze kit.

Testing Plan

  • Was this tested locally? If not, explain why.
  • Verified through compilation and execution of a local application, as well as running the unit test case to validate the functionality.

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

BrandonStalnaker
BrandonStalnaker requested changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@BrandonStalnaker BrandonStalnaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic for parsing the consent mapping and sending it to Braze all looks good. Just some minor questions and cleanup I saw.

src/main/kotlin/com/mparticle/kits/AppboyKit.kt Outdated Show resolved Hide resolved
src/main/kotlin/com/mparticle/kits/AppboyKit.kt Show resolved Hide resolved
@Mansi-mParticle Mansi-mParticle force-pushed the feat/SQDSDKS-6386-Google-EU-consent branch from fb2fa7e to c201a65 Compare September 10, 2024 18:14
BrandonStalnaker
BrandonStalnaker approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@BrandonStalnaker BrandonStalnaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@einsteinx2 einsteinx2 merged commit 7812b65 into development Sep 11, 2024
16 checks passed
@einsteinx2 einsteinx2 deleted the feat/SQDSDKS-6386-Google-EU-consent branch September 11, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrandonStalnaker BrandonStalnaker BrandonStalnaker approved these changes

@rmi22186 rmi22186 rmi22186 approved these changes

@samdozor samdozor Awaiting requested review from samdozor

@einsteinx2 einsteinx2 Awaiting requested review from einsteinx2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mansi-mParticle @rmi22186 @BrandonStalnaker @einsteinx2