Skip to content

Commit

Permalink
Address review comment
Browse files Browse the repository at this point in the history
  • Loading branch information
Mansi-mParticle committed Sep 10, 2024
1 parent 6636088 commit fb2fa7e
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 14 deletions.
2 changes: 1 addition & 1 deletion src/main/kotlin/com/mparticle/kits/AppboyKit.kt
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ import kotlin.collections.HashMap
* mParticle client-side Appboy integration
*/
open class AppboyKit : KitIntegration(), AttributeListener, CommerceListener,
KitIntegration.EventListener, PushListener, IdentityListener ,KitIntegration.UserAttributeListener {
KitIntegration.EventListener, PushListener, IdentityListener, KitIntegration.UserAttributeListener {

var enableTypeDetection = false
var bundleCommerceEvents = false
Expand Down
20 changes: 7 additions & 13 deletions src/test/kotlin/com/mparticle/kits/AppboyKitTest.kt
Original file line number Diff line number Diff line change
@@ -1,16 +1,12 @@
package com.mparticle.kits

import android.app.Activity
import android.content.Context
import android.net.Uri
import android.util.SparseBooleanArray
import com.braze.Braze
import com.braze.models.outgoing.BrazeProperties
import com.mparticle.MPEvent
import com.mparticle.MParticle
import com.mparticle.MParticle.IdentityType
import com.mparticle.MParticleOptions
import com.mparticle.MParticleOptions.DataplanOptions
import com.mparticle.commerce.CommerceEvent
import com.mparticle.commerce.Impression
import com.mparticle.commerce.Product
Expand All @@ -20,8 +16,6 @@ import com.mparticle.consent.ConsentState
import com.mparticle.consent.GDPRConsent
import com.mparticle.identity.IdentityApi
import com.mparticle.identity.MParticleUser
import com.mparticle.internal.CoreCallbacks
import com.mparticle.internal.CoreCallbacks.KitListener
import com.mparticle.kits.mocks.MockAppboyKit
import com.mparticle.kits.mocks.MockContextApplication
import com.mparticle.kits.mocks.MockKitConfiguration
Expand All @@ -34,9 +28,7 @@ import org.junit.Before
import org.junit.Test
import org.mockito.Mock
import org.mockito.Mockito
import org.mockito.Mockito.mock
import org.mockito.MockitoAnnotations
import java.lang.ref.WeakReference
import java.lang.reflect.Method
import java.math.BigDecimal
import java.util.Calendar
Expand Down Expand Up @@ -1096,11 +1088,13 @@ class AppboyKitTests {
fun testSearchKeyInNestedMap_When_Input_Key_Is_Empty_String() {
val kit = MockAppboyKit()
val map = mapOf(
"GDPR" to true,
"marketing" to mapOf(
"consented" to false,
"document" to mapOf(
"timestamp" to 1711038269644
"FeatureEnabled" to true,
"settings" to mapOf(
"darkMode" to false,
"notifications" to mapOf(
"email" to false,
"push" to true,
"lastUpdated" to 1633046400000L
)
)
)
Expand Down

0 comments on commit fb2fa7e

Please sign in to comment.