Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kasiah/empower connector #1191
Kasiah/empower connector #1191
Changes from all commits
33ded2c
ebf5c9d
082fa10
8321f0b
fbe7e48
5314e44
04ce2ba
f2650da
64ec284
a950c17
c811091
a25d9d1
1d62e64
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels a little weird to pull this out into its own method since it's only used once? But if we think it's likely we'll want re-use the helper method again might as well keep it separated out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's enough data restructuring happening in this method that I would appreciate some code comments to help readers understand what's happening (ie so for instance one doesn't have to go read the docstring for
unpack_nested_columns_as_rows
to know the precise behavior - could just say# unpacks answerIdsByPromptId into standalone rows
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enough data restructuring is happening in these methods (or the private/utility methods they're calling) that it would be useful for each of the dcostrings for the public methods to describe the format of the data being returned.