Kasiah/empower connector #1191
Merged
Kasiah/empower connector #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaunagm
requested changes
Nov 19, 2024
|
|
||
| return [ctas, cta_prompts, cta_prompt_answers] | ||
|
|
||
| def get_ctas(self): |
There was a problem hiding this comment.
Enough data restructuring is happening in these methods (or the private/utility methods they're calling) that it would be useful for each of the dcostrings for the public methods to describe the format of the data being returned.
shaunagm
reviewed
Nov 19, 2024
shaunagm
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
One small additional change requested (re: the unix timestamp) but otherwise this looks good enough. I do wish there was a bit more documentation of how the methods are constructed and what they're doing to the data but I understand since you didn't write the code yourself that's hard to provide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branched off @jburchard 's Empower connector PR.
Adds a single method to return the full export unparsed, for pure ELT.