Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: instrumented broker is crashing when calling aedes.subscribe #3

Conversation

getlarge
Copy link
Member

@getlarge getlarge added bug Something isn't working documentation Improvements or additions to documentation labels Sep 22, 2023
@getlarge getlarge linked an issue Sep 22, 2023 that may be closed by this pull request
@robertsLando
Copy link
Member

Also I would try do do a dry run with release-it because I dunno if that works when changlog file is not present, maybe you have to firstly generate it as the release-it plugin should work in append mode

@getlarge
Copy link
Member Author

Also I would try do do a dry run with release-it because I dunno if that works when changlog file is not present, maybe you have to firstly generate it as the release-it plugin should work in append mode

it looks like this :

0.1.1 (2023-09-25)

Bug Fixes

  • correctly create and close spans when no client is defined in Aedes methods (961db1a)

Test added

  • ensure broker.subscribe can be used by consumer (15de1a4)

Chores

  • add changelog generator (8970b43)

@robertsLando
Copy link
Member

it looks like this :

Perfect so!

@getlarge getlarge merged commit 5380e07 into main Sep 26, 2023
4 checks passed
@getlarge getlarge deleted the 2-bug-instrumented-broker-is-crashing-when-calling-aedessubscribe branch September 26, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: instrumented broker is crashing when calling aedes.subscribe
2 participants