Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for broker as a client #5

Open
getlarge opened this issue Sep 26, 2023 · 0 comments
Open

feat: add support for broker as a client #5

getlarge opened this issue Sep 26, 2023 · 0 comments

Comments

@getlarge
Copy link
Member

i get the idea and agree with it, that would be quite a refactoring of the span management logic.
right now, spans are only focused around the client, changing this to also support the broker as the client would involve several changes, beyond changing the functions signatures.
That would also involve :

  • checking when the client is the broker
  • storing some attributes into the broker to reuse during span creation
  • ensuring that the broker instance is always accessible to manage spans, even though that one should be easy if we consider that the places where “broker is the client” is when calling the broker instance methods
  • adding some tests obviously

I would rather do this work in a separate issue/PR.

Originally posted by @getlarge in #3 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant