Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch multiple slashes in source dataset into one slash #1697

Merged
merged 4 commits into from
Dec 13, 2024
Merged

Catch multiple slashes in source dataset into one slash #1697

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5ce2048
catch UC not found
Dec 12, 2024
58092c0
catch double slash
Dec 13, 2024
1f3be0b
rm old code
Dec 13, 2024
d453c76
use pathlib instead
Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion llmfoundry/utils/config_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import logging
import math
import os
import re
import warnings
from dataclasses import dataclass, fields
from typing import (
Expand Down Expand Up @@ -703,6 +704,8 @@ def _process_data_source(
true_split (str): The split of the dataset to be added (i.e. train or eval)
data_paths (List[Tuple[str, str, str]]): A list of tuples formatted as (data type, path, split)
"""
if source_dataset_path:
source_dataset_path = re.sub(r'/+', '/', source_dataset_path)
# Check for Delta table
if source_dataset_path and len(source_dataset_path.split('.')) == 3:
data_paths.append(('delta_table', source_dataset_path, true_split))
Expand Down Expand Up @@ -788,7 +791,6 @@ def log_dataset_uri(cfg: dict[str, Any]) -> None:

# Map data source types to their respective MLFlow DataSource.
for dataset_type, path, split in data_paths:

if dataset_type in dataset_source_mapping:
source_class = dataset_source_mapping[dataset_type]
if dataset_type == 'delta_table':
Expand Down
Loading