Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch multiple slashes in source dataset into one slash #1697

Merged
merged 4 commits into from
Dec 13, 2024

Conversation

KuuCi
Copy link
Contributor

@KuuCi KuuCi commented Dec 12, 2024

As title suggests, trying to catch wrong input for UC where user accidentally adds multiple slashes

Test:
On main:
test-uc-mlflow-IEv1zp
image

On branch:
test-uc-mlflow-8yeqFa
image

Trains properly now with s broken dummy path:
image

@KuuCi KuuCi changed the title Catch UC not found Catch multiple slashes in source dataset into one slash Dec 13, 2024
@KuuCi KuuCi requested a review from dakinggg December 13, 2024 01:01
@KuuCi KuuCi marked this pull request as ready for review December 13, 2024 01:01
@KuuCi KuuCi requested a review from a team as a code owner December 13, 2024 01:01
Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't think you need to write your own regex

In [1]: from pathlib import Path

In [2]: str(Path('dbfs:/Volumes/blah/blah//blah.jsonl'))
Out[2]: 'dbfs:/Volumes/blah/blah/blah.jsonl'

@KuuCi
Copy link
Contributor Author

KuuCi commented Dec 13, 2024

retested:
image

@KuuCi KuuCi requested a review from dakinggg December 13, 2024 01:12
@KuuCi KuuCi merged commit c494017 into main Dec 13, 2024
9 checks passed
@KuuCi KuuCi deleted the catch-not-exist-in-UC branch December 13, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants