Use a temporary directory for downloading finetuning dataset files #1608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irenedea
changed the title
mvpatel2000
reviewed
Oct 23, 2024
irenedea
commented
Oct 23, 2024
mvpatel2000
approved these changes
Oct 24, 2024
dakinggg
added a commit
to dakinggg/llm-foundry
that referenced
this pull request
Nov 4, 2024
…files (mosaicml#1608)" This reverts commit ed6b72b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses a temporary directory to download finetuning files to. Similar to mosaicml/composer#3673
This avoids issues where the working directory has limits on file sizes or permission restrictions. This also enables more configurability because we can set the default temp dir if needed.
Manual Tests
jsonl file
test-tempdir-finetuning-jsonl-file-Jh9IH6jsonl file on 16 gpus
test-tempdir-finetuning-jsonl-file-16-gpus-Lxmfdvhf dataset + safeload
test-tempdir-finetuning-hf-dataset-DxwRw9hf dataset + safeload on 16 gpus
test-tempdir-finetuning-hf-dataset-16-gpus-OkPHge