Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use a temporary directory for downloading finetuning dataset … #1637

Closed
wants to merge 3 commits into from

Conversation

dakinggg
Copy link
Collaborator

@dakinggg dakinggg commented Nov 4, 2024

…files (#1608)"

This reverts commit ed6b72b.

This PR resulted in hugging face datasets sometimes hanging during processing. Likely it interfered with datasets caching logic. Confirmed it resolves it with 8 successful runs.

@dakinggg dakinggg marked this pull request as ready for review November 4, 2024 23:50
@dakinggg dakinggg requested a review from a team as a code owner November 4, 2024 23:50
@dakinggg dakinggg closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants