Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix load and save planner config logic #1385

Merged
merged 2 commits into from
Jul 23, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions llmfoundry/command_utils/train.py
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ def train(cfg: DictConfig) -> Trainer:

if fsdp_config is not None:
if 'load_planner' in fsdp_config:
load_planners = fsdp_config['load_planner'].items()
load_planners = list(fsdp_config['load_planner'].items())
if len(load_planners) > 1:
raise ValueError(
'Only one load planner can be specified in the config.',
Expand All @@ -272,7 +272,7 @@ def train(cfg: DictConfig) -> Trainer:
)

if 'save_planner' in fsdp_config:
save_planners = fsdp_config['save_planner'].items()
save_planners = list(fsdp_config['save_planner'].items())
if len(save_planners) > 1:
raise ValueError(
'Only one save planner can be specified in the config.',
Expand Down
Loading