Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix load and save planner config logic #1385

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Fix load and save planner config logic #1385

merged 2 commits into from
Jul 23, 2024

Conversation

irenedea
Copy link
Contributor

@irenedea irenedea commented Jul 22, 2024 •
edited
Loading

Fixes the load and save planner logic. 'dict_items' object is not subscriptable, so it needs to be converted to a list.

@irenedea irenedea requested a review from a team as a code owner July 22, 2024 23:44
dakinggg
dakinggg approved these changes Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add pr description, but lgtm

@irenedea irenedea enabled auto-merge (squash) July 22, 2024 23:50
snarayan21
snarayan21 approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fire

@irenedea irenedea merged commit 0bed4ff into mosaicml:main Jul 23, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakinggg dakinggg dakinggg approved these changes

@snarayan21 snarayan21 snarayan21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@irenedea @snarayan21 @dakinggg