DRIVERS-3023 Add spec tests for GridFS rename and require client errors #1700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
requested review from
dariakp and
alcaeus
and removed request for
a team and
dariakp
alcaeus
reviewed
Oct 30, 2024
source/gridfs/tests/rename.yml
Outdated
| arguments: | ||
| id: { "$oid": "000000000000000000000003" } | ||
| newFilename: newfilename | ||
| expectError: { isError: true } # FileNotFound |
There was a problem hiding this comment.
@jmikola should this use isClientError: true?
There was a problem hiding this comment.
I updated all the gridfs spec tests to use isClientError, this schemaVersion is not affected.
GromNaN
changed the title
alcaeus
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix DRIVERS-3023
Please complete the following before merging:
clusters, and serverless).