Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPLIB-1574 Add spec tests for GridFS Bucket rename #1507

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Oct 30, 2024

Fix PHPLIB-1574

First implementation awaiting mongodb/specifications#1700

@GromNaN GromNaN changed the title DRIVERS-3023 Add spec tests for GridFS Bucket rename PHPLIB-1574 Add spec tests for GridFS Bucket rename Oct 30, 2024
@GromNaN GromNaN marked this pull request as ready for review October 30, 2024 12:35
@GromNaN GromNaN requested a review from a team as a code owner October 30, 2024 12:35
@GromNaN GromNaN requested a review from alcaeus October 30, 2024 12:35
@alcaeus
Copy link
Member

alcaeus commented Oct 30, 2024

Changes LGTM, let's wait until the spec change is merged.

@GromNaN GromNaN changed the base branch from v1.x to dependabot/submodules/tests/specifications-34f9a57 October 31, 2024 09:59
@alcaeus
Copy link
Member

alcaeus commented Oct 31, 2024

Can you remove the commit to update the specs repository, as that's already included in the dependabot PR?

Update spec tests

Update specifications
@GromNaN
Copy link
Member Author

GromNaN commented Oct 31, 2024

I put out my best Git knowledge for squash and reset the git submodule version.

@GromNaN GromNaN merged commit 7dfa3e8 into mongodb:dependabot/submodules/tests/specifications-34f9a57 Oct 31, 2024
14 of 15 checks passed
@GromNaN GromNaN deleted the DRIVERS-3023 branch October 31, 2024 10:51
GromNaN added a commit that referenced this pull request Oct 31, 2024
* Bump tests/specifications from `9058491` to `34f9a57`

Bumps [tests/specifications](https://github.com/mongodb/specifications) from `9058491` to `34f9a57`.
- [Release notes](https://github.com/mongodb/specifications/releases)
- [Commits](mongodb/specifications@9058491...34f9a57)

---
updated-dependencies:
- dependency-name: tests/specifications
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

* DRIVERS-3023 Add spec tests for GridFS Bucket rename (#1507)

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jérôme Tamarelle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants