Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOP-5203: change Chatbot access from search input to button #1311

Merged
merged 18 commits into from
Nov 27, 2024
Merged

Conversation

seungpark
Copy link
Collaborator

@seungpark seungpark commented Nov 22, 2024

Stories/Links:

DOP-5203

Current Behavior:

current manual docs with dropdown search input

Staging Links:

docs manual with chatbot action button
404 page verification
Landing preview should be below on the deploy preview from netlify
staged a mocked translated site here to show chatbot button being hidden

Notes:

  • There were some places where the alignment was not correct, so addressed these in this PR. ie. https://www.mongodb.com/docs/ at 1840px to 2000px

README updates

    • This PR introduces changes that should be reflected in the README, and I have made those updates.
    • This PR does not introduce changes that should be reflected in the README

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for docs-frontend-dotcomprd ready!

Name Link
🔨 Latest commit c0926d5
🔍 Latest deploy log https://app.netlify.com/sites/docs-frontend-dotcomprd/deploys/6740aef2d79e2300084618f4
😎 Deploy Preview https://deploy-preview-1311--docs-frontend-dotcomprd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for docs-frontend-dotcomstg ready!

Name Link
🔨 Latest commit c0926d5
🔍 Latest deploy log https://app.netlify.com/sites/docs-frontend-dotcomstg/deploys/6740aef2fe9445000881b659
😎 Deploy Preview https://deploy-preview-1311--docs-frontend-dotcomstg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for docs-frontend-stg ready!

Name Link
🔨 Latest commit c0926d5
🔍 Latest deploy log https://app.netlify.com/sites/docs-frontend-stg/deploys/6740aef286dcef00080e8967
😎 Deploy Preview https://deploy-preview-1311--docs-frontend-stg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for docs-frontend-dotcomprd ready!

Name Link
🔨 Latest commit 8b29ebb
🔍 Latest deploy log https://app.netlify.com/sites/docs-frontend-dotcomprd/deploys/674629cf433cde000880f850
😎 Deploy Preview https://deploy-preview-1311--docs-frontend-dotcomprd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for docs-frontend-dotcomstg ready!

Name Link
🔨 Latest commit 8b29ebb
🔍 Latest deploy log https://app.netlify.com/sites/docs-frontend-dotcomstg/deploys/674629cfd8fde10008302e6d
😎 Deploy Preview https://deploy-preview-1311--docs-frontend-dotcomstg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for docs-frontend-stg ready!

Name Link
🔨 Latest commit 8b29ebb
🔍 Latest deploy log https://app.netlify.com/sites/docs-frontend-stg/deploys/674629cfa7cf080008e129ec
😎 Deploy Preview https://deploy-preview-1311--docs-frontend-stg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@seungpark seungpark marked this pull request as ready for review November 22, 2024 17:50
src/components/ActionBar/SearchInput.js Outdated Show resolved Hide resolved
src/components/ActionBar/SearchInput.js Outdated Show resolved Hide resolved
src/components/ActionBar/ActionBar.js Outdated Show resolved Hide resolved
src/components/ActionBar/SearchInput.js Outdated Show resolved Hide resolved
src/components/ActionBar/ActionBar.js Outdated Show resolved Hide resolved
src/components/ActionBar/ActionBar.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@mmeigs mmeigs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such a nit but I'm wondering if we want to switch over to the mobile action bar sooner OR just allow the search bar to scrunch more. There are about 20 pixels worth of screensize where the styling is rough.

Screenshot 2024-11-25 at 9 31 57 AM

src/components/ActionBar/SearchInput.js Outdated Show resolved Hide resolved
src/components/ActionBar/SearchInput.js Outdated Show resolved Hide resolved
src/components/ActionBar/styles.js Outdated Show resolved Hide resolved
src/components/ActionBar/ActionBar.js Outdated Show resolved Hide resolved
src/components/ActionBar/LazyChatbot.js Outdated Show resolved Hide resolved
src/components/ActionBar/styles.js Outdated Show resolved Hide resolved
src/components/ActionBar/ActionBar.js Outdated Show resolved Hide resolved
package-lock.json Show resolved Hide resolved
@seungpark seungpark requested a review from rayangler November 25, 2024 21:39
src/components/ActionBar/styles.js Outdated Show resolved Hide resolved
src/components/ActionBar/styles.js Outdated Show resolved Hide resolved
src/components/ActionBar/styles.js Show resolved Hide resolved
Copy link
Collaborator

@rayangler rayangler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@seungpark seungpark merged commit 53ba6b7 into main Nov 27, 2024
14 checks passed
@seungpark seungpark deleted the DOP-5203 branch November 27, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants