-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-revert: Skunkworks: Upload Lighthouse Scores to Atlas #83
Merged
Merged
Changes from 37 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
267083d
upload-lighthouse
mmeigs 694c9b8
lighthouse
mmeigs 5182105
install
mmeigs 45e7bea
types and bundle
mmeigs bbbd645
remove dotenv import
mmeigs f8f1e3b
new action, packaged
mmeigs d9948fb
json
mmeigs a923be8
change target, module, and moduleResolution
mmeigs 1773376
rebundle with new logs
mmeigs 66c72e0
babel
mmeigs 4fb42fb
module
mmeigs 1529e1f
ar
mmeigs 8d7943f
new packaged
mmeigs e20a304
allow forward
mmeigs a60e5dc
package new reading
mmeigs d5194da
upload reports
mmeigs ce04805
close db, use correct properties to get average
mmeigs 9c34056
re-package
mmeigs 27d9548
use summary
mmeigs 895cd39
typing
mmeigs 31ed6be
repackage
mmeigs 202b99c
clean up old logic
mmeigs 1d95371
repackage
mmeigs 47245e8
lint and fix extra complications
mmeigs e25ca4e
attempt at making code more DRY
mmeigs 527de38
format
mmeigs eff3dd0
packaged
mmeigs 6876510
clean
mmeigs 1389f16
packaged
mmeigs fbd97dd
add extra averages
mmeigs c88c1b8
lint
mmeigs d08a8c1
revert tsconfig, package
mmeigs cc819c5
lint
mmeigs 592ae76
show context
mmeigs feae5ac
linting
mmeigs 2d5d071
use new msg, time
mmeigs aeef02a
iso date
mmeigs d73e963
remove type module
mmeigs 4c2dc47
remove package.json
mmeigs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we have the diffs here if no change in tsconfig?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great question: two possible answers. I had "type": "module" in the package.json. I've just removed that.
Also, couuuld be the upgrade of mongodb, but most likely it's the statement above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^^ I think it was both? I removed
"type": "module"and deleted all the extra package.jsons that had been created for that. So, I have to believe its the mongodb upgrade? Nothing else is different.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like that did the trick 👍 only certain bundles are updated with version / license updates only