Re-revert: Skunkworks: Upload Lighthouse Scores to Atlas #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seungpark
reviewed
Jun 18, 2024
dist/build-artifact/index.js
Outdated
There was a problem hiding this comment.
why do we have the diffs here if no change in tsconfig?
There was a problem hiding this comment.
Great question: two possible answers. I had "type": "module" in the package.json. I've just removed that.
Also, couuuld be the upgrade of mongodb, but most likely it's the statement above.
There was a problem hiding this comment.
^^ I think it was both? I removed "type": "module" and deleted all the extra package.jsons that had been created for that. So, I have to believe its the mongodb upgrade? Nothing else is different.
There was a problem hiding this comment.
seems like that did the trick 👍 only certain bundles are updated with version / license updates only
seungpark
approved these changes
Jun 18, 2024
mmeigs
force-pushed
the
skunk-upload-lighthouse
branch
from
c95586e to
4c2dc47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same PR that failed last week's deployment but with all tsconfig changes removed! No other changes have happened to the PR.
Reference to previous PR's description.
More info:
Options on displaying this information still being decided. But primary objective is persisting runs to the database so that future decisions will still have past data.