⭐️ delayed asset discovery

[imilchev]

needs #3492

[github-actions]

Test Results

2 854 tests  +5   2 853 ✅ +5   1m 22s ⏱️ -8s
  186 suites ±0       1 💤 ±0 
    5 files   ±0       0 ❌ ±0 

Results for commit 023880f. ± Comparison against base commit eed1b07.

This pull request removes 3 and adds 8 tests. Note that renamed tests count towards both.

go.mondoo.com/cnquery/v10/llx ‑ TestSuccess/2024-03-06_10:34:20.294474983_+0000_UTC_m=+0.008575732
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-03-06_10:34:20.294474983_+0000_UTC_m=+0.008575732
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-03-06_10:34:20.294474983_+0000_UTC_m=+0.008575732#01

go.mondoo.com/cnquery/v10/llx ‑ TestSuccess/2024-03-06_13:44:55.107182654_+0000_UTC_m=+0.006560970
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-03-06_13:44:55.107182654_+0000_UTC_m=+0.006560970
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-03-06_13:44:55.107182654_+0000_UTC_m=+0.006560970#01
go.mondoo.com/cnquery/v10/providers-sdk/v1/plugin ‑ TestDeprecatedAddRuntime_DisableDelayedDiscovery
go.mondoo.com/cnquery/v10/providers/os/connection/container ‑ TestNewImageConnection_DelayDiscovery
go.mondoo.com/cnquery/v10/providers/os/connection/container ‑ TestNewImageConnection_DisableDelayDiscovery
go.mondoo.com/cnquery/v10/providers/os/connection/docker ‑ TestAssetNameForRemoteImages_DisableDelayedDiscovery
go.mondoo.com/cnquery/v10/providers/os/provider ‑ TestLocalConnectionIdDetectors_DelayedDiscovery

♻️ This comment has been updated with latest results.

[czunker]

Why or in which cases should this be used?

Is it intended, that this is not exposed as a flag?

[czunker]

Could we add a check for the platform here and in the other test?

Here, we shouldn't have any platform information. In the other test we should know it is an alpine image.

[imilchev]

discovery is handled in the provider, not in the connection. At this point, we never have a platform regardless of the flag. There are tests that verify the provider sets the platform based on the flag in the provider tests

[imilchev]

Why or in which cases should this be used?

Is it intended, that this is not exposed as a flag?

I am not sure I understand the question. This is an inventory setting. There is nothing for the user to specify here. The goal is that every provider knows which discovery takes a lot memory, disk space or IO. It is up to the provider to decide whether delayed discovery should be used for an asset or not. If delayed discovery is used, then just 1 operation at a time will be active during a scan. That's not something the user should decide or care about