Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 disable os detection for registry images #3291

Closed
wants to merge 1 commit into from

Conversation

imilchev
Copy link
Member

this makes sure we aren't pulling the container unless we are running a scan

Copy link
Contributor

github-actions bot commented Feb 13, 2024

Test Results

    5 files  ± 0    186 suites  ±0   39s ⏱️ -6s
2 729 tests  - 10  2 726 ✅  - 12  1 💤 ±0  2 ❌ +2 
2 728 runs   - 11  2 725 ✅  - 13  1 💤 ±0  2 ❌ +2 

For more details on these failures, see this check.

Results for commit 59893a8. ± Comparison against base commit 9220b11.

This pull request removes 14 and adds 4 tests. Note that renamed tests count towards both.
go.mondoo.com/cnquery/v10/llx ‑ TestSuccess/2024-02-13_14:16:01.294140372_+0100_CET_m=+0.007327776
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-02-13_14:16:01.294140372_+0100_CET_m=+0.007327776
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-02-13_14:16:01.294140372_+0100_CET_m=+0.007327776#01
go.mondoo.com/cnquery/v10/providers/os/connection ‑ TestAssetNameForRemoteImages
go.mondoo.com/cnquery/v10/providers/os/connection ‑ TestFilePermissions
go.mondoo.com/cnquery/v10/providers/os/connection ‑ TestPlatformIdentifier
go.mondoo.com/cnquery/v10/providers/os/connection ‑ TestSSHAuthError
go.mondoo.com/cnquery/v10/providers/os/connection ‑ TestSSHDefaultSettings
go.mondoo.com/cnquery/v10/providers/os/connection ‑ TestSSHProviderError
go.mondoo.com/cnquery/v10/providers/os/connection ‑ TestTarCommand
…
TestMain
go.mondoo.com/cnquery/v10/llx ‑ TestSuccess/2024-02-13_12:48:55.789449567_+0100_CET_m=+0.008750179
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-02-13_12:48:55.789449567_+0100_CET_m=+0.008750179
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-02-13_12:48:55.789449567_+0100_CET_m=+0.008750179#01

♻️ This comment has been updated with latest results.

@imilchev imilchev force-pushed the ivan/disable-os-detection-containers branch from 7d26245 to 1c6030e Compare February 13, 2024 16:23
@imilchev imilchev force-pushed the ivan/disable-os-detection-containers branch from 1c6030e to 59893a8 Compare February 13, 2024 17:33
@imilchev
Copy link
Member Author

imilchev commented Mar 6, 2024

fixed in #3496

@imilchev imilchev closed this Mar 6, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant