-
-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(enhanced): support layers in consume share plugin #3276
Open
ScriptedAlchemy
wants to merge
44
commits into
main
Choose a base branch
from
consume-share-layers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 28 commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
5b107fa
feat(enhanced): support layers
ScriptedAlchemy 062706f
feat(enhanced): support layers
ScriptedAlchemy cfd9d01
feat(enhanced): layers for consume shared module
ScriptedAlchemy 3e59c55
Merge branch 'main' into layers-support
ScriptedAlchemy 536b110
Merge branch 'main' into layers-support
ScriptedAlchemy aed08e9
feat(enhanced): add issuerLayer support to consume shared
ScriptedAlchemy 9fb164b
chore(enhanced): update test
ScriptedAlchemy a9d899c
chore(enhanced): update test
ScriptedAlchemy 33a36d1
feat(enhanced): ConsumeSharedPlugin issuerLayer support
ScriptedAlchemy f0c5c50
chore: update tests for layer combos
ScriptedAlchemy 578adbb
chore: update tests for layer combos
ScriptedAlchemy 31f08d0
chore: update tests for layer combos
ScriptedAlchemy 066ffa6
feat(enhanced): support direct layer
ScriptedAlchemy b70eb8d
Merge branch 'main' into layers-support
ScriptedAlchemy 358ba00
fix(enhanced): update share options of share plugin
ScriptedAlchemy 94d72ed
fix(enhanced): update share options of share plugin
ScriptedAlchemy 91dbb12
chore(enhanced): refactor layers tests
ScriptedAlchemy 514cf03
chore(enhanced): remove layer options from provider
ScriptedAlchemy 359b0ca
Merge branch 'main' into consume-share-layers
ScriptedAlchemy 24ef6d0
Delete .cursorrules
ScriptedAlchemy 9d9bff2
feat(enhanced): support layers in consume share
ScriptedAlchemy 40ae817
Merge branch 'main' into consume-share-layers
ScriptedAlchemy d1c68b3
fix(enhanced): rename requiredLayer to layer
ScriptedAlchemy 22964f8
Merge remote-tracking branch 'origin/consume-share-layers' into consu…
ScriptedAlchemy 9884030
Merge branch 'main' into consume-share-layers
ScriptedAlchemy 3d8fa21
refactor(enhanced): pr review of consume share layering
ScriptedAlchemy 69a2a52
Merge branch 'main' into consume-share-layers
ScriptedAlchemy 04b8ffd
chore: locks
ScriptedAlchemy 7852878
feat(enhanced): add request to consume share (#3307)
ScriptedAlchemy f35b1b1
Merge branch 'main' into consume-share-layers
ScriptedAlchemy b8df73e
chore: remove tt
ScriptedAlchemy b4b5a7b
chore: remove unused share
ScriptedAlchemy 6f8f45e
refactor(enhanced): refactor type locations
ScriptedAlchemy 875f516
feat(enhanced): ProvideSharedPlugin loader layer support (#3334)
ScriptedAlchemy 673f6ca
Merge branch 'main' into consume-share-layers
ScriptedAlchemy 20bae5b
chore: locks
ScriptedAlchemy a5774c8
chore(enhanced): add share plugin test
ScriptedAlchemy d44acbd
chore(enhanced): add share plugin test
ScriptedAlchemy 1a33ac7
chore(enhanced): add share plugin test
ScriptedAlchemy 1fc2b05
thing
ScriptedAlchemy 29f6d73
thing
ScriptedAlchemy 22127ee
chore(node): lint
ScriptedAlchemy 8f9fb99
chore(node): lint
ScriptedAlchemy 243f1bc
Merge branch 'main' into consume-share-layers
ScriptedAlchemy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be handled in the
unresolvedConsumes.get
case belowThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ive opened up a new PR with additional adjustments for this, it becomes hard to control due to how request is used.
I propose adding another option explicitly for controlling the request matching.