Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(enhanced): support layers in consume share plugin #3276

Open
wants to merge 44 commits into
base: main
Choose a base branch
from

Conversation

ScriptedAlchemy
Copy link
Member

@ScriptedAlchemy ScriptedAlchemy commented Nov 25, 2024

Description

This pull request introduces several enhancements and fixes to the module sharing functionality in the enhanced package. The changes include updating the ConsumeSharedModule and ConsumeSharedPlugin to support module layers, adding a new Jest command to the package.json, and updating schema validation for the ConsumeSharedPlugin.

    new ConsumeSharedPlugin({
      consumes: {
        react: {
          singleton: true,
        },
        'explicit-layer-react': {
          import: 'react/index2',
          shareKey: 'react',
          singleton: true,
          issuerLayer: 'differing-layer',
          layer: 'explicit-layer',
        },
        'differing-layer-react': {
          import: 'react',
          shareKey: 'react',
          singleton: true,
          layer: 'required-layer',
        },
        'layered-react': {
          import: 'react',
          shareKey: 'react',
          singleton: true,
          issuerLayer: 'other-layer',
        },
      },
    }),

    new ProvideSharedPlugin({
      shareScope: 'default',
      provides: {
        react: {
          shareKey: 'react',
          version: '17.0.2',
          singleton: true,
        },
        'explicit-layer-react': {
          request: 'react/index2',
          shareKey: 'react',
          version: '17.0.2',
          singleton: true,
          layer: 'explicit-layer',
        },
        'differing-layer-react': {
          request: 'react',
          shareKey: 'react',
          version: '17.0.2',
          singleton: true,
          layer: 'differing-layer',
        },
        'required-layer-react': {
          request: 'react',
          shareKey: 'react',
          version: '17.0.2',
          singleton: true,
          layer: 'required-layer',
        },
        'lib-two': {
          shareKey: 'lib-two',
          request: 'lib2',
          version: '1.3.4',
          requiredVersion: '^1.0.0',
          strictVersion: true,
          eager: false,
        },
        'lib-two-layered': {
          request: 'lib2',
          shareKey: 'lib-two',
          version: '1.3.4',
          requiredVersion: '^1.0.0',
          strictVersion: true,
          eager: true,
          layer: 'lib-two-layer',
        },
        'lib-two-required': {
          request: 'lib2',
          shareKey: 'lib-two',
          version: '1.3.4',
          requiredVersion: '^1.0.0',
          strictVersion: true,
          eager: true,
          layer: 'lib-two-required-layer',
        },
        'multi-pkg/': {
          version: '2.0.0',
          requiredVersion: '^2.0.0',
          strictVersion: true,
          eager: true,
        },
        'multi-layered': {
          request: 'multi-pkg/',
          version: '2.0.0',
          requiredVersion: '^2.0.0',
          strictVersion: true,
          eager: true,
          layer: 'multi-pkg-layer',
        },
      },
    }),

    new SharePlugin({
      shareScope: 'default',
      shared: {
        react: {
          singleton: true,
        },
        'explicit-layer-react': {
          request: 'react/index2',
          import: 'react/index2',
          shareKey: 'react',
          singleton: true,
          issuerLayer: 'differing-layer',
          layer: 'explicit-layer',
        },
        'differing-layer-react': {
          request: 'react',
          import: 'react',
          shareKey: 'react',
          singleton: true,
          issuerLayer: 'differing-layer',
          layer: 'differing-layer',
        },
        'lib-two': {
          request: 'lib-two',
          import: 'lib2',
          requiredVersion: '^1.0.0',
          version: '1.3.4',
          strictVersion: true,
          eager: false,
        },
        nonsense: {
          request: 'lib-two',
          import: 'lib2',
          shareKey: 'lib-two',
          requiredVersion: '^1.0.0',
          version: '1.3.4',
          strictVersion: true,
          eager: true,
          issuerLayer: 'lib-two-layer',
          layer: 'differing-layer',
        },
        'lib-two-layered': {
          import: 'lib2',
          shareKey: 'lib-two',
          requiredVersion: '^1.0.0',
          version: '1.3.4',
          strictVersion: true,
          eager: true,
          issuerLayer: 'lib-two-layer',
          layer: 'differing-layer',
        },
        multi: {
          request: 'multi-pkg/',
          requiredVersion: '^2.0.0',
          version: '2.0.0',
          strictVersion: true,
          eager: true,
        },
      },
    }),

Enhancements to Module Sharing:

Updates to package.json:

  • package.json: Added a new Jest command ("enhanced:jest": "pnpm build && cd packages/enhanced && NODE_OPTIONS=--experimental-vm-modules npx jest test/ConfigTestCases.basictest.js") and updated the webpack-cli dependency to version ^5.1.4. [1] [2]

Schema Validation:

Note

Runtime module aspects still need to be updated, this is the compiler mechanics only for module. Runtime parts will likely be done once the other half of share plugin has layer support

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

Copy link

changeset-bot bot commented Nov 25, 2024

🦋 Changeset detected

Latest commit: 243f1bc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 27 packages
Name Type
@module-federation/enhanced Major
@module-federation/modern-js Major
@module-federation/nextjs-mf Patch
@module-federation/node Patch
@module-federation/rsbuild-plugin Major
@module-federation/storybook-addon Patch
@module-federation/modernjsapp Patch
@module-federation/runtime Major
@module-federation/rspack Major
@module-federation/webpack-bundler-runtime Major
@module-federation/sdk Major
@module-federation/runtime-tools Major
@module-federation/managers Major
@module-federation/manifest Major
@module-federation/dts-plugin Major
@module-federation/third-party-dts-extractor Major
@module-federation/devtools Major
@module-federation/bridge-react Major
@module-federation/bridge-vue3 Major
@module-federation/bridge-shared Major
@module-federation/bridge-react-webpack-plugin Major
@module-federation/retry-plugin Major
@module-federation/data-prefetch Major
@module-federation/error-codes Major
@module-federation/esbuild Patch
@module-federation/utilities Patch
website-new Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit 243f1bc
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/675bb7c71c4e1e000869483c
😎 Deploy Preview https://deploy-preview-3276--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@squadronai squadronai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

Here is a concise summary of the pull request:

This pull request introduces several enhancements to the module sharing functionality in the enhanced package. The key changes include:

  • Added support for specifying and resolving module layers in the ConsumeSharedModule and ConsumeSharedPlugin classes, allowing for more granular control over how modules are shared and consumed. This includes new properties like layer, issuerLayer, and requiredLayer.
  • Updated the ConsumeSharedPlugin class to handle layer-specific requests and factorize modules based on the layer context.
  • Added a new Jest command to the package.json file to run specific test cases for the layer-related functionality, and updated the webpack-cli dependency.
  • Implemented TypeScript-based validation functions for the ConsumeSharedPlugin schema to ensure proper validation of the new layer-related properties.

These changes aim to enhance the module sharing capabilities in the enhanced package by introducing support for module layers, improving the overall module management and resolution process.

File Summaries
File Summary
packages/enhanced/src/declarations/plugins/sharing/ConsumeSharedModule.d.ts The code changes in this pull request focus on enhancing the module sharing functionality in the enhanced package. The key modifications are:
  1. Added support for specifying and resolving module layers in the ConsumeSharedModule class, including new properties like layer, issuerLayer, and requiredLayer in the ConsumeOptions type. This allows for more granular control over how modules are shared and consumed.

  2. Updated the ConsumeSharedPlugin class to handle layer-specific requests and factorize modules based on the layer context. New properties like issuerLayer and requiredLayer were added to the plugin options to facilitate this functionality.

  3. Added a new Jest command to the package.json file to run specific test cases for the ConfigTestCases.basictest.js file, and updated the webpack-cli dependency to version ^5.1.4.

  4. Implemented TypeScript-based validation functions for the ConsumeSharedPlugin schema to ensure proper validation of the new properties related to module layers.

Overall, these changes aim to enhance the module sharing capabilities in the enhanced package by introducing support for module layers, which allows for more flexible and granular control over how modules are shared and consumed within the application. |
| packages/enhanced/src/declarations/plugins/sharing/ConsumeSharedPlugin.d.ts | The code changes introduce several enhancements and fixes to the module sharing functionality in the enhanced package. The key modifications include adding support for specifying and resolving module layers in the ConsumeSharedModule and ConsumeSharedPlugin classes, updating the package.json file to include a new Jest command, and adding TypeScript-based validation functions for the ConsumeSharedPlugin schema to ensure proper validation of the new properties. |
| packages/enhanced/src/declarations/plugins/sharing/ProvideSharedPlugin.d.ts | The code changes introduce several enhancements and fixes to the module sharing functionality in the enhanced package. The key modifications include:

  1. Adding support for specifying and resolving module layers in the ConsumeSharedModule and ConsumeSharedPlugin classes, with new properties like layer, issuerLayer, and requiredLayer.

  2. Updating the ConsumeSharedPlugin class to handle layer-specific requests and factorize modules based on the layer context.

  3. Adding a new Jest command to the package.json file to run a specific test case, and updating the webpack-cli dependency.

  4. Introducing TypeScript-based validation functions for the ConsumeSharedPlugin schema to ensure proper validation of the new properties. |
    | packages/enhanced/src/declarations/plugins/sharing/SharePlugin.d.ts | The code changes introduce several enhancements and fixes to the module sharing functionality in the enhanced package. The key modifications include adding support for specifying and resolving module layers in the ConsumeSharedModule and ConsumeSharedPlugin classes, updating the package.json file to include a new Jest command, and adding TypeScript-based validation functions for the ConsumeSharedPlugin schema to ensure proper validation of the new properties. |
    | packages/enhanced/src/lib/sharing/ConsumeSharedModule.ts | The changes in this pull request focus on enhancing the module sharing functionality in the enhanced package. The key modifications are:

  5. Added support for specifying and resolving module layers in the ConsumeSharedModule and ConsumeSharedPlugin classes. This includes introducing new properties like layer, issuerLayer, and requiredLayer to handle layer-specific requests and factorize modules based on the layer context.

  6. Updated the package.json file by adding a new Jest command to run specific test cases for the ConfigTestCases.basictest.js file, and also updated the webpack-cli dependency to version ^5.1.4.

  7. Implemented TypeScript-based validation functions for the ConsumeSharedPlugin schema to ensure proper validation of the new layer-related properties. |
    | packages/enhanced/src/lib/sharing/ConsumeSharedPlugin.ts | The code changes in this pull request focus on enhancing the module sharing functionality in the enhanced package. The key modifications are:

  8. Updated the ConsumeSharedModule and ConsumeSharedPlugin classes to support module layers, adding new properties like layer, issuerLayer, and requiredLayer to handle layer-specific requests and factorize modules based on the layer context.

  9. Added a new Jest command to the package.json file to run a specific test case for the ConfigTestCases.basictest.js file.

  10. Updated the schema validation for the ConsumeSharedPlugin to ensure proper validation of the new layer-related properties. |
    | packages/enhanced/src/lib/sharing/ProvideSharedDependency.ts | The code changes introduce support for module layers in the ConsumeSharedModule and ConsumeSharedPlugin classes. The key modifications are:

  11. Added new properties (layer, issuerLayer, requiredLayer) to the ConsumeOptions type and updated the ConsumeSharedModule class to handle layer-specific requests and factorize modules based on layer context.

  12. Updated the ConsumeSharedPlugin class to support layer-specific requests and added issuerLayer and requiredLayer properties to the plugin options.

  13. Added TypeScript-based validation functions for the ConsumeSharedPlugin schema to ensure proper validation of the new properties.

  14. Added a new Jest command to the package.json file and updated the webpack-cli dependency to version ^5.1.4. |
    | packages/enhanced/src/lib/sharing/ProvideSharedModule.ts | The code changes in this pull request focus on enhancing the module sharing functionality in the enhanced package. The key modifications are:

  15. Updated the ConsumeSharedModule and ConsumeSharedPlugin classes to support module layers, adding new properties like layer, issuerLayer, and requiredLayer to handle layer-specific requests and factorize modules based on the layer context.

  16. Added a new Jest command to the package.json file to run a specific test case for the ConfigTestCases.basictest.js file, and updated the webpack-cli dependency to version ^5.1.4.

  17. Added TypeScript-based validation functions for the ConsumeSharedPlugin schema to ensure proper validation of the new properties related to module layers. |
    | packages/enhanced/src/lib/sharing/ProvideSharedPlugin.ts | The key changes in this file are:

  18. The ProvideSharedPlugin class has been updated to support module layers. This includes adding new properties like layer and request to the ProvidesConfig type, and introducing a createLookupKey function to handle layer-specific requests.

  19. The plugin's apply method has been modified to maintain a resolvedProvideMap that tracks the provided modules, their configurations, and associated versions. This map is now keyed by a composite key that includes the layer information.

  20. The provideSharedModule function has been updated to store the resource information in the resolvedProvideMap in addition to the configuration and version.

  21. The normalModuleFactory.hooks.module tap has been modified to check the resolvedProvideMap using the layer-aware lookup key, and provide the shared module if a match is found.

  22. The compilation.addInclude call in the afterCompile hook has been updated to use the resource or the composite lookup key, depending on whether the resource information is available.

Overall, these changes aim to enhance the module sharing functionality in the ProvideSharedPlugin by introducing support for module layers, improving the resolution and tracking of provided modules, and ensuring that the plugin can handle layer-specific requests. |
| packages/enhanced/src/lib/sharing/SharePlugin.ts | The code changes introduce several enhancements and fixes to the module sharing functionality in the enhanced package. The key modifications include:

  1. Adding support for specifying and resolving module layers in the ConsumeSharedModule class, with new properties like layer, issuerLayer, and requiredLayer added to the ConsumeOptions type.

  2. Updating the ConsumeSharedPlugin class to handle layer-specific requests and factorize modules based on the layer context, with the addition of issuerLayer and requiredLayer properties to the plugin options.

  3. Adding a new Jest command to the package.json file to run a specific test case, and updating the webpack-cli dependency to version ^5.1.4.

  4. Implementing TypeScript-based validation functions for the ConsumeSharedPlugin schema to ensure proper validation of the new properties. |
    | packages/enhanced/src/lib/sharing/resolveMatchedConfigs.ts | The code changes in this pull request focus on enhancing the module sharing functionality in the enhanced package. The key modifications are:

  5. Updated the ConsumeSharedModule and ConsumeSharedPlugin classes to support module layers, adding new properties (layer, issuerLayer, requiredLayer) to handle layer-specific requests and factorize modules based on the layer context.

  6. Added a new Jest command to the package.json file to run a specific test case for the ConfigTestCases.basictest.js file.

  7. Added TypeScript-based validation functions for the ConsumeSharedPlugin schema to ensure proper validation of the new properties.

The changes aim to improve the module sharing capabilities by introducing support for module layers, which allows for more granular control and management of shared modules within the application. |
| packages/enhanced/src/schemas/sharing/ConsumeSharedPlugin.check.ts | The changes in this file focus on enhancing the schema validation for the ConsumeSharedPlugin in the enhanced package. The key modifications are:

  1. Added support for validating new properties (layer, issuerLayer, requiredLayer) in the ConsumeOptions type, which were introduced to enable module layer handling in the ConsumeSharedModule and ConsumeSharedPlugin classes.
  2. Implemented TypeScript-based validation functions to ensure proper validation of the new properties, along with the existing properties like import, packageName, requiredVersion, shareKey, shareScope, singleton, and strictVersion.
  3. The validation logic covers checking the data types, lengths, and presence of the required properties to ensure the ConsumeSharedPlugin configuration is valid.

Overall, these changes aim to provide a robust schema validation mechanism for the module sharing functionality in the enhanced package, particularly with the introduction of module layer support. |
| packages/enhanced/src/schemas/sharing/ConsumeSharedPlugin.ts | The changes in this pull request focus on enhancing the module sharing functionality in the enhanced package. The key modifications are:

  1. Updated the ConsumeSharedModule and ConsumeSharedPlugin classes to support module layers, adding new properties like layer, issuerLayer, and requiredLayer to handle layer-specific requests and factorize modules based on the layer context.

  2. Added a new Jest command to the package.json file to run a specific test case for the ConfigTestCases.basictest.js file, and updated the webpack-cli dependency to version ^5.1.4.

  3. Introduced TypeScript-based validation functions for the ConsumeSharedPlugin schema to ensure proper validation of the new layer-related properties. |
    | packages/enhanced/src/schemas/sharing/ProviderSharedPlugin.check.ts | The code changes introduce several enhancements and fixes to the module sharing functionality in the enhanced package. The key modifications are:

  4. Added support for specifying and resolving module layers in the ConsumeSharedModule and ConsumeSharedPlugin classes, including new properties like layer, issuerLayer, and requiredLayer.

  5. Updated the ConsumeSharedPlugin class to handle layer-specific requests and factorize modules based on the layer context.

  6. Added a new Jest command to the package.json file to run a specific test case for the ConfigTestCases.basictest.js file.

  7. Added TypeScript-based validation functions for the ConsumeSharedPlugin schema to ensure proper validation of the new properties. |
    | packages/enhanced/src/schemas/sharing/ProviderSharedPlugin.ts | The code changes introduce several enhancements and fixes to the module sharing functionality in the enhanced package. The key modifications include:

  8. Adding support for specifying and resolving module layers in the ConsumeSharedModule and ConsumeSharedPlugin classes, with new properties like layer, issuerLayer, and requiredLayer to handle layer-specific requests and factorize modules based on layer context.

  9. Updating the package.json file to add a new Jest command for testing the ConfigTestCases.basictest.js file and upgrading the webpack-cli dependency.

  10. Implementing TypeScript-based validation functions for the ConsumeSharedPlugin schema to ensure proper validation of the new properties. |
    | packages/enhanced/test/configCases/sharing/layers-consume-loader/src/index.js | The code changes introduce several enhancements and fixes to the module sharing functionality in the enhanced package. The key modifications include:

  11. Adding support for specifying and resolving module layers in the ConsumeSharedModule and ConsumeSharedPlugin classes, allowing for more granular control over module sharing and consumption.

  12. Updating the ConsumeSharedPlugin class to handle layer-specific requests and factorize modules based on the layer context, improving the overall module sharing experience.

  13. Adding a new Jest command to the package.json file to facilitate testing of the layer-related functionality, and updating the webpack-cli dependency to the latest version.

  14. Implementing TypeScript-based validation functions for the ConsumeSharedPlugin schema to ensure proper validation of the new layer-related properties. |
    | packages/enhanced/test/configCases/sharing/layers-provides-loader/src/index.js | The code changes introduce several enhancements and fixes to the module sharing functionality in the enhanced package. The key modifications include:

  15. Adding support for specifying and resolving module layers in the ConsumeSharedModule and ConsumeSharedPlugin classes, allowing for more granular control over module sharing.

  16. Updating the package.json file to include a new Jest command for testing the layer-specific functionality, and bumping the webpack-cli dependency to a newer version.

  17. Implementing TypeScript-based validation functions for the ConsumeSharedPlugin schema to ensure proper validation of the new layer-related properties.

These changes aim to improve the module sharing capabilities of the enhanced package, particularly in scenarios where module layers need to be considered. |
| packages/enhanced/test/configCases/sharing/layers-share-plugin/src/index.js | The code changes introduce several enhancements and fixes to the module sharing functionality in the enhanced package. The key modifications include:

  1. Adding support for specifying and resolving module layers in the ConsumeSharedModule and ConsumeSharedPlugin classes, allowing for more granular control over module sharing.
  2. Updating the ConsumeSharedPlugin class to handle layer-specific requests and factorize modules based on the layer context.
  3. Adding a new Jest command to the package.json file to run a specific test case for the ConfigTestCases.basictest.js file.
  4. Implementing TypeScript-based validation functions for the ConsumeSharedPlugin schema to ensure proper validation of the new properties related to module layers. |

Copy link
Contributor

@squadronai squadronai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incremental Review

Comments posted: 11

Configuration

Squadron Mode: essential

Commits Reviewed

e26d10712d98c450b9ae57babdfab27dee9e1dad...24ef6d05e48f9cb5f128479f515714e50028e780

Files Reviewed
  • packages/enhanced/src/declarations/plugins/sharing/ConsumeSharedPlugin.d.ts
  • packages/enhanced/src/declarations/plugins/sharing/SharePlugin.d.ts
  • packages/enhanced/src/lib/sharing/ConsumeSharedModule.ts
  • packages/enhanced/src/lib/sharing/ConsumeSharedPlugin.ts
  • packages/enhanced/src/lib/sharing/SharePlugin.ts
Files Ignored

These files were ignored due to the filter in the squadron.yaml file.

  • package.json
  • packages/enhanced/test/configCases/sharing/layers-consume-entry/.gitignore
  • packages/enhanced/test/configCases/sharing/layers-consume-entry/async-boundary.js
  • packages/enhanced/test/configCases/sharing/layers-consume-entry/index-test.js
  • packages/enhanced/test/configCases/sharing/layers-consume-entry/index.js
  • packages/enhanced/test/configCases/sharing/layers-consume-entry/layer-exporter.js
  • packages/enhanced/test/configCases/sharing/layers-consume-entry/node_modules/react/index.js
  • packages/enhanced/test/configCases/sharing/layers-consume-entry/node_modules/react/index2.js
  • packages/enhanced/test/configCases/sharing/layers-consume-entry/package.json
  • packages/enhanced/test/configCases/sharing/layers-consume-entry/test.config.js
  • packages/enhanced/test/configCases/sharing/layers-consume-entry/webpack.config.js
  • packages/enhanced/test/configCases/sharing/layers-consume-loader/.gitignore
  • packages/enhanced/test/configCases/sharing/layers-consume-loader/loaders/different-layer-loader.js
  • packages/enhanced/test/configCases/sharing/layers-consume-loader/loaders/explicit-layer-loader.js
  • packages/enhanced/test/configCases/sharing/layers-consume-loader/loaders/react-layer-loader.js
  • packages/enhanced/test/configCases/sharing/layers-consume-loader/node_modules/react/index.js
  • packages/enhanced/test/configCases/sharing/layers-consume-loader/node_modules/react/index2.js
  • packages/enhanced/test/configCases/sharing/layers-consume-loader/package.json
  • packages/enhanced/test/configCases/sharing/layers-consume-loader/shared/react-boundary.js
  • packages/enhanced/test/configCases/sharing/layers-consume-loader/test.config.js
  • packages/enhanced/test/configCases/sharing/layers-consume-loader/tests/different-layers.test.js
  • packages/enhanced/test/configCases/sharing/layers-consume-loader/tests/layer-inheritance.test.js
  • packages/enhanced/test/configCases/sharing/layers-consume-loader/tests/unlayered-share.test.js
  • packages/enhanced/test/configCases/sharing/layers-consume-loader/webpack.config.js
  • pnpm-lock.yaml

@module-federation module-federation deleted a comment from squadronai bot Nov 26, 2024
@module-federation module-federation deleted a comment from squadronai bot Nov 26, 2024
@module-federation module-federation deleted a comment from squadronai bot Nov 26, 2024
Copy link
Contributor

@squadronai squadronai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incremental Review

Comments posted: 11

Configuration

Squadron Mode: essential

Commits Reviewed

40ae81768f47bbce75b3d6f88dfb5826a1d94774...04b8ffdd26412715669fa17f9413b0d5b7275d23

Files Reviewed
  • packages/enhanced/src/declarations/plugins/sharing/ConsumeSharedPlugin.d.ts
  • packages/enhanced/src/declarations/plugins/sharing/SharePlugin.d.ts
  • packages/enhanced/src/lib/sharing/ConsumeSharedPlugin.ts
  • packages/enhanced/src/lib/sharing/SharePlugin.ts
  • packages/enhanced/src/schemas/sharing/ConsumeSharedPlugin.check.ts
  • packages/enhanced/src/schemas/sharing/ConsumeSharedPlugin.ts
Files Ignored

These files were ignored due to the filter in the squadron.yaml file.

  • package.json
  • packages/enhanced/test/configCases/sharing/layers-consume-entry/.gitignore
  • packages/enhanced/test/configCases/sharing/layers-consume-entry/async-boundary.js
  • packages/enhanced/test/configCases/sharing/layers-consume-entry/index-test.js
  • packages/enhanced/test/configCases/sharing/layers-consume-entry/index.js
  • packages/enhanced/test/configCases/sharing/layers-consume-entry/layer-exporter.js
  • packages/enhanced/test/configCases/sharing/layers-consume-entry/node_modules/react/index.js
  • packages/enhanced/test/configCases/sharing/layers-consume-entry/node_modules/react/index2.js
  • packages/enhanced/test/configCases/sharing/layers-consume-entry/package.json
  • packages/enhanced/test/configCases/sharing/layers-consume-entry/test.config.js
  • packages/enhanced/test/configCases/sharing/layers-consume-entry/webpack.config.js
  • packages/enhanced/test/configCases/sharing/layers-consume-loader/.gitignore
  • packages/enhanced/test/configCases/sharing/layers-consume-loader/loaders/different-layer-loader.js
  • packages/enhanced/test/configCases/sharing/layers-consume-loader/loaders/explicit-layer-loader.js
  • packages/enhanced/test/configCases/sharing/layers-consume-loader/loaders/react-layer-loader.js
  • packages/enhanced/test/configCases/sharing/layers-consume-loader/node_modules/react/index.js
  • packages/enhanced/test/configCases/sharing/layers-consume-loader/node_modules/react/index2.js
  • packages/enhanced/test/configCases/sharing/layers-consume-loader/package.json
  • packages/enhanced/test/configCases/sharing/layers-consume-loader/shared/react-boundary.js
  • packages/enhanced/test/configCases/sharing/layers-consume-loader/test.config.js
  • packages/enhanced/test/configCases/sharing/layers-consume-loader/tests/different-layers.test.js
  • packages/enhanced/test/configCases/sharing/layers-consume-loader/tests/layer-inheritance.test.js
  • packages/enhanced/test/configCases/sharing/layers-consume-loader/tests/unlayered-share.test.js
  • packages/enhanced/test/configCases/sharing/layers-consume-loader/webpack.config.js
  • pnpm-lock.yaml

@module-federation module-federation deleted a comment from squadronai bot Dec 5, 2024
@module-federation module-federation deleted a comment from squadronai bot Dec 5, 2024
@module-federation module-federation deleted a comment from squadronai bot Dec 5, 2024
@module-federation module-federation deleted a comment from squadronai bot Dec 5, 2024
@module-federation module-federation deleted a comment from squadronai bot Dec 5, 2024
@module-federation module-federation deleted a comment from squadronai bot Dec 5, 2024
@module-federation module-federation deleted a comment from squadronai bot Dec 5, 2024
@module-federation module-federation deleted a comment from squadronai bot Dec 5, 2024
@module-federation module-federation deleted a comment from squadronai bot Dec 5, 2024
@module-federation module-federation deleted a comment from squadronai bot Dec 5, 2024
@module-federation module-federation deleted a comment from squadronai bot Dec 5, 2024
@ScriptedAlchemy ScriptedAlchemy requested a review from sokra December 5, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants